From: Arnd Bergmann <arnd@arndb.de>
To: michael.hennerich@analog.com
Cc: greg@kroah.com, device-drivers-devel@blackfin.uclinux.org,
drivers@analog.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] misc: ad525x_dpot: Add support for SPI module device table matching
Date: Tue, 22 Nov 2011 16:11:19 +0000 [thread overview]
Message-ID: <201111221611.19190.arnd@arndb.de> (raw)
In-Reply-To: <1321610711-12507-2-git-send-email-michael.hennerich@analog.com>
On Friday 18 November 2011, michael.hennerich@analog.com wrote:
> From: Michael Hennerich <michael.hennerich@analog.com>
>
> Passing device name via platform data, is a leftover from times where
> SPI module device table matching was not existent.
>
> * Add id_table and remove old mechanism.
> (To my knowledge no intree boards affected)
> * Miscellaneous other cleanup.
The patch looks good to me, but please don't do "miscelaneous other cleanup"
in the same patch. I think doing cleanups while you change a driver is
a good idea, just do the extra step to split those out into a cleanup
patch and describe what you do, just like you have split out the bug fix.
Arnd
next prev parent reply other threads:[~2011-11-22 16:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-18 10:05 [PATCH 1/2] misc: ad525x_dpot: Fix AD8400 spi transfer size michael.hennerich
2011-11-18 10:05 ` [PATCH 2/2] misc: ad525x_dpot: Add support for SPI module device table matching michael.hennerich
2011-11-22 16:11 ` Arnd Bergmann [this message]
2011-11-22 17:03 ` Hennerich, Michael
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201111221611.19190.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=device-drivers-devel@blackfin.uclinux.org \
--cc=drivers@analog.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.hennerich@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®