From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Stephen Boyd <sboyd@codeaurora.org>
Cc: Will Deacon <will.deacon@arm.com>, Arnd Bergmann <arnd@arndb.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 1/2] ARM: debug: Add CLSP711X_UART1 config choice
Date: Tue, 22 Nov 2011 20:42:38 +0000 [thread overview]
Message-ID: <20111122204238.GE9581@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <4E77C84E.9040202@codeaurora.org>
On Mon, Sep 19, 2011 at 03:55:10PM -0700, Stephen Boyd wrote:
> Ah ok. How about this instead?
Better...
> diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug
> index 9661c51..31896f4 100644
> --- a/arch/arm/Kconfig.debug
> +++ b/arch/arm/Kconfig.debug
> @@ -93,14 +93,19 @@ choice
> It does include a timeout to ensure that the system does not
> totally freeze when there is nothing connected to read.
>
> + config DEBUG_FOOTBRIDGE_COM1
> + bool "Kernel low-level debugging messages via footbridge 8250 at PCI COM1"
I don't think PC-isms help here - especially when these aren't labelled
using this terminology on devices. Netwinder called it just a simple
"Serial" on the rear panel.
bool "Kernel low-level debugging messages via 8250 serial port at 0x3f8"
> + depends on FOOTBRIDGE
> + help
> + Say Y here if you want the debug print routines to direct
> + their output to the 8250 at PCI COM1.
Same kind of fixup here. Other than that, it seems fine.
next prev parent reply other threads:[~2011-11-22 20:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20110916114140.GA31334@e102144-lin.cambridge.arm.com>
2011-09-19 18:01 ` Stephen Boyd
2011-09-19 18:01 ` [PATCH 2/2] ARM: debug: Move DEBUG_ICEDCC into the DEBUG_LL choice Stephen Boyd
2011-09-19 21:25 ` [PATCH 1/2] ARM: debug: Add CLSP711X_UART1 config choice Will Deacon
2011-09-19 22:12 ` Stephen Boyd
2011-09-19 22:41 ` Russell King - ARM Linux
2011-09-19 22:55 ` Stephen Boyd
2011-11-22 20:42 ` Russell King - ARM Linux [this message]
2011-09-19 23:14 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111122204238.GE9581@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sboyd@codeaurora.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®