mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "J. Bruce Fields" <bfields@fieldses.org>
To: Sasha Levin <levinsasha928@gmail.com>
Cc: linux-kernel@vger.kernel.org, Neil Brown <neilb@suse.de>,
	linux-nfs@vger.kernel.org
Subject: Re: [PATCH] nfsd: Fix oops when parsing a 0 length export
Date: Tue, 22 Nov 2011 15:59:30 -0500	[thread overview]
Message-ID: <20111122205930.GG21451@fieldses.org> (raw)
In-Reply-To: <1321994009.3787.19.camel@lappy>

On Tue, Nov 22, 2011 at 10:33:29PM +0200, Sasha Levin wrote:
> On Tue, 2011-11-22 at 15:28 -0500, J. Bruce Fields wrote:
> > On Fri, Nov 18, 2011 at 12:14:49PM +0200, Sasha Levin wrote:
> > > expkey_parse() oopses when handling a 0 length export. This is easily
> > > triggerable from usermode by writing 0 bytes into
> > > '/proc/[proc id]/net/rpc/nfsd.fh/channel'.
> > 
> > Thanks--how did you run across this?
> > 
> > --b.
> 
> Tried running a fuzzer on the system.

OK, thanks.  As far as I can tell this could only be hit by a privileged
user doing something stupid.  And the bug has been there forever.

So I'm inclined just to queue this up for 3.3.

--b.

  reply	other threads:[~2011-11-22 20:59 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-18 10:14 Sasha Levin
2011-11-22 20:28 ` J. Bruce Fields
2011-11-22 20:33   ` Sasha Levin
2011-11-22 20:59     ` J. Bruce Fields [this message]
2012-01-16 11:52 ` [patch] nfsd: oopses in cache_parse() Dan Carpenter
2012-01-16 15:50   ` J. Bruce Fields
2012-01-18  9:55     ` Dan Carpenter
2012-01-18  9:56     ` [patch] nfsd: don't allow zero length strings " Dan Carpenter
2012-01-18 22:41       ` J. Bruce Fields
2012-01-20  7:48         ` [patch] nfsd: remove some unneeded checks Dan Carpenter
2012-01-20 18:35           ` J. Bruce Fields

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111122205930.GG21451@fieldses.org \
    --to=bfields@fieldses.org \
    --cc=levinsasha928@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=neilb@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®