From: Tejun Heo <tj@kernel.org>
To: Steven Rostedt <rostedt@goodmis.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Ingo Molnar <mingo@redhat.com>, Jiri Olsa <jolsa@redhat.com>
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH 1/2] trace_events_filter: use rcu_assign_pointer() when setting ftrace_event_call->filter
Date: Tue, 22 Nov 2011 17:46:03 -0800 [thread overview]
Message-ID: <20111123014603.GA19630@google.com> (raw)
ftrace_event_call->filter is sched RCU protected but didn't use
rcu_assign_pointer(). Fix it.
TODO: Add proper __rcu annotation to call->filter and all its users.
Signed-off-by: Tejun Heo <tj@kernel.org>
---
kernel/trace/trace_events_filter.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
Index: work/kernel/trace/trace_events_filter.c
===================================================================
--- work.orig/kernel/trace/trace_events_filter.c
+++ work/kernel/trace/trace_events_filter.c
@@ -1686,7 +1686,7 @@ static int replace_system_preds(struct e
* replace the filter for the call.
*/
filter = call->filter;
- call->filter = filter_item->filter;
+ rcu_assign_pointer(call->filter, filter_item->filter);
filter_item->filter = filter;
fail = false;
@@ -1741,7 +1741,7 @@ int apply_event_filter(struct ftrace_eve
filter = call->filter;
if (!filter)
goto out_unlock;
- call->filter = NULL;
+ rcu_assign_pointer(call->filter, NULL);
/* Make sure the filter is not being used */
synchronize_sched();
__free_filter(filter);
@@ -1782,7 +1782,7 @@ out:
* string
*/
tmp = call->filter;
- call->filter = filter;
+ rcu_assign_pointer(call->filter, filter);
if (tmp) {
/* Make sure the call is done with the filter */
synchronize_sched();
next reply other threads:[~2011-11-23 1:46 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-23 1:46 Tejun Heo [this message]
2011-11-23 2:00 ` [PATCH 2/2] trace_event_filter: factorize filter creation Tejun Heo
2011-11-23 15:19 ` Steven Rostedt
2011-11-23 15:59 ` Tejun Heo
2011-11-28 20:49 ` Tejun Heo
2011-11-28 22:15 ` Steven Rostedt
2011-12-08 23:32 ` Tejun Heo
2011-12-09 0:15 ` Steven Rostedt
2011-12-09 0:46 ` Steven Rostedt
2011-12-09 18:55 ` Tejun Heo
2011-12-09 19:43 ` [PATCH 2/2 UPDATED] " Tejun Heo
2011-11-23 15:16 ` [PATCH 1/2] trace_events_filter: use rcu_assign_pointer() when setting ftrace_event_call->filter Steven Rostedt
2011-11-23 16:06 ` Tejun Heo
2011-11-23 16:12 ` Tejun Heo
2011-11-23 17:06 ` Steven Rostedt
2011-11-23 17:33 ` Tejun Heo
2011-11-28 16:49 ` Paul E. McKenney
2011-11-23 16:40 ` Eric Dumazet
2011-11-23 16:44 ` Tejun Heo
2011-11-23 16:49 ` [PATCH UPDATED " Tejun Heo
2011-12-05 17:34 ` [tip:perf/urgent] trace_events_filter: Use " tip-bot for Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111123014603.GA19630@google.com \
--to=tj@kernel.org \
--cc=fweisbec@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome