From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756450Ab1KWDWy (ORCPT ); Tue, 22 Nov 2011 22:22:54 -0500 Received: from hqemgate04.nvidia.com ([216.228.121.35]:7188 "EHLO hqemgate04.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755071Ab1KWDWw (ORCPT ); Tue, 22 Nov 2011 22:22:52 -0500 X-PGP-Universal: processed; by hqnvupgp06.nvidia.com on Tue, 22 Nov 2011 19:22:30 -0800 Date: Wed, 23 Nov 2011 05:22:27 +0200 From: Peter De Schrijver To: Olof Johansson CC: Grant Likely , Rob Herring , Randy Dunlap , Russell King , Colin Cross , Stephen Warren , "devicetree-discuss@lists.ozlabs.org" , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-tegra@vger.kernel.org" Subject: Re: [PATCH 06/10] arm/tegra: prepare pinmux code for multiple tegra variants Message-ID: <20111123032227.GO19069@tbergstrom-lnx.Nvidia.com> References: <1321546766-26770-1-git-send-email-pdeschrijver@nvidia.com> <1321546766-26770-7-git-send-email-pdeschrijver@nvidia.com> <20111118214116.GC31678@quad.lixom.net> <20111121142919.GN19069@tbergstrom-lnx.Nvidia.com> <20111122190146.GA31361@quad.lixom.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20111122190146.GA31361@quad.lixom.net> X-NVConfidentiality: public User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 22, 2011 at 08:01:46PM +0100, Olof Johansson wrote: > On Mon, Nov 21, 2011 at 04:29:19PM +0200, Peter De Schrijver wrote: > > On Fri, Nov 18, 2011 at 10:41:16PM +0100, Olof Johansson wrote: > > > On Thu, Nov 17, 2011 at 06:19:20PM +0200, Peter De Schrijver wrote: > > > > This patch modifies the pinmux code to be useable for multiple tegra variants. > > > > Some tegra20 specific constants will be replaced by variables which will be > > > > initialized to the appropriate value at runtime. > > > > > > > > Signed-off-by: Peter De Schrijver > > > > --- > > > > arch/arm/mach-tegra/board-harmony-pcie.c | 1 + > > > > arch/arm/mach-tegra/board-harmony-pinmux.c | 1 + > > > > arch/arm/mach-tegra/board-paz00-pinmux.c | 1 + > > > > arch/arm/mach-tegra/board-trimslice-pinmux.c | 1 + > > > > arch/arm/mach-tegra/include/mach/pinmux.h | 25 +++---- > > > > arch/arm/mach-tegra/pinmux-tegra20-tables.c | 15 +++- > > > > arch/arm/mach-tegra/pinmux.c | 105 ++++++++++++++----------- > > > > 7 files changed, 86 insertions(+), 63 deletions(-) > > > > > > > > diff --git a/arch/arm/mach-tegra/board-harmony-pcie.c b/arch/arm/mach-tegra/board-harmony-pcie.c > > > > index 6db7d69..bd402d0 100644 > > > > --- a/arch/arm/mach-tegra/board-harmony-pcie.c > > > > +++ b/arch/arm/mach-tegra/board-harmony-pcie.c > > > > @@ -23,6 +23,7 @@ > > > > #include > > > > > > > > #include > > > > +#include > > > > > > Boards shouldn't have to include this. The idea is that you should only > > > have to do board code against the pinmux.h interface, which internally > > > abstracts it for tegra 20 vs tegra 30. > > > > The pinmux naming is still SoC specific. Unless we move this to devicetree > > (which should be part of a different patchset), I don't see how we can solve > > this, except by renaming all the pingroups. That would cause a lot more > > changes though. > > If the pinmux naming and numbering is unique per SoC then sharing > namespace for them could be a source of confusion. If we need to keep > them around much longer, then doing that rename would be a good idea. But > we can do that separately from this change. So the include change is ok > for now. > > My other comments about the code changes still stands though, so please > address those. > I'm working on those. I'm on a businesstrip now, so things might go a bit slower. Cheers, Peter.