mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "K.Prasad" <prasad@linux.vnet.ibm.com>
To: Vivek Goyal <vgoyal@redhat.com>
Cc: linux-kernel@vger.kernel.org, Borislav Petkov <bp@alien8.de>,
	"Luck, Tony" <tony.luck@intel.com>,
	"Eric W. Biederman" <ebiederm@xmission.com>,
	anderson@redhat.com, tachibana@mxm.nes.nec.co.jp,
	oomichi@mxs.nes.nec.co.jp, Valdis.Kletnieks@vt.edu,
	Nick Bowler <nbowler@elliptictech.com>
Subject: Re: [RFC Patch 0/2] Slimdump framework using CRASH_REASON - v2
Date: Wed, 23 Nov 2011 23:03:18 +0530	[thread overview]
Message-ID: <20111123173318.GB2515@in.ibm.com> (raw)
In-Reply-To: <20111121151727.GF313@redhat.com>

On Mon, Nov 21, 2011 at 10:17:27AM -0500, Vivek Goyal wrote:
> On Mon, Nov 21, 2011 at 03:24:05PM +0530, K.Prasad wrote:
> > Hi All,
> > 	In furtherance of the previous discussion regarding 'slimdump'
> > (refer: http://article.gmane.org/gmane.linux.kernel/1204967), it was
> > decided that,
> > 
> > - An entry in VMCOREINFO elf-note be added to denote the cause of crash,
> >   instead of creating a new elf-note.
> > 
> > - Upstream tools such as 'makedumpfile' and 'crash' be modified to
> >   recognise this string and inform the user accordingly.
> > 
> > Accordingly, this new version of the patchset makes the following
> > changes 
> > 
> > Changelog - version 2
> > -----------------------
> > (First version posted here:
> > http://article.gmane.org/gmane.linux.kernel/1198435)
> > 
> > - Append VMCOREINFO elf-note with a new variable CRASH_REASON whose
> >   value will be populated using arch_add_crash_reason() function.
> > 
> > - Define arch_add_crash_reason() in the x86 MCE path to return "PANIC_MCE"
> >   in the panic path of MCE.
> > 
> > - 'makedumpfile' tool is taught to recognise PANIC_MCE string as one
> >   value of CRASH_REASON for which 'slimdump' must be captured.
> 
> So again, what is slimdump? I mean, what information is now being captured
> in the case of slimdump? Are you capturing atleast the kernel message
> buffers? I am assuming that any register info emitted on console will
> make into kernel buffers and that should be useful to figure out what
> MCE happened.
> 

The kernel message buffers can be obtained by using the --dump-dmesg
option of makedumpfile but again that's risky. We wouldn't know if it'll
cause access to the faulty memory (which is how the previous method of having
a new elf-notes in a pristine location is much safer).

The method in this patch is quite primitive in that informs the user
nothing more than a one-line cause of crash. One should take help from other
tools (such as service processor/firmware/ACPI logs, or previous corrected
error logs) to infer the location of bad memory. It would have been helpful
if we could provide a dump of related information such as contents of
"struct mce" (like in the very first iteration of the patch,
refer: http://article.gmane.org/gmane.linux.kernel/1146215), but that would
need some memory (possibly in the form of a new elf-note).

Thanks,
K.Prasad


  reply	other threads:[~2011-11-23 17:33 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-21  9:54 K.Prasad
2011-11-21 10:11 ` [RFC Patch 1/2][slimdump] Append CRASH_REASON to VMCOREINFO elf-note K.Prasad
2011-11-21 15:11   ` Vivek Goyal
2011-11-23 16:14     ` K.Prasad
2011-11-21 15:19   ` Dave Anderson
2011-11-23 17:39     ` K.Prasad
2011-11-28 14:26       ` Vivek Goyal
2011-11-23 17:42     ` K.Prasad
2011-11-23 19:45       ` Dave Anderson
2011-11-29 14:37         ` K.Prasad
2011-11-21 10:14 ` [RFC Patch 2/2][slimdump][makedumpfile] Recognise PANIC_MCE crashes to generate slimdu K.Prasad
2011-11-21 15:17 ` [RFC Patch 0/2] Slimdump framework using CRASH_REASON - v2 Vivek Goyal
2011-11-23 17:33   ` K.Prasad [this message]
2011-11-28 14:24     ` Vivek Goyal
2011-11-30 17:15       ` K.Prasad

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111123173318.GB2515@in.ibm.com \
    --to=prasad@linux.vnet.ibm.com \
    --cc=Valdis.Kletnieks@vt.edu \
    --cc=anderson@redhat.com \
    --cc=bp@alien8.de \
    --cc=ebiederm@xmission.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nbowler@elliptictech.com \
    --cc=oomichi@mxs.nes.nec.co.jp \
    --cc=tachibana@mxm.nes.nec.co.jp \
    --cc=tony.luck@intel.com \
    --cc=vgoyal@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®