From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754088Ab1K1UUF (ORCPT ); Mon, 28 Nov 2011 15:20:05 -0500 Received: from ogre.sisk.pl ([217.79.144.158]:60696 "EHLO ogre.sisk.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753652Ab1K1UUC (ORCPT ); Mon, 28 Nov 2011 15:20:02 -0500 From: "Rafael J. Wysocki" To: Jeff Layton Subject: Re: [PATCH v3 0/2] nfs/sunrpc: allow freezing of tasks with NFS calls in flight Date: Mon, 28 Nov 2011 21:22:53 +0100 User-Agent: KMail/1.13.6 (Linux/3.2.0-rc3+; KDE/4.6.0; x86_64; ; ) Cc: linux-kernel@vger.kernel.org, linux-nfs@vger.kernel.org, linux-pm@vger.kernel.org, tj@kernel.org, john@calva.com, trond.myklebust@netapp.com, marek.belisko@gmail.com, awilliam@redhat.com References: <1322510488-21189-1-git-send-email-jlayton@redhat.com> In-Reply-To: <1322510488-21189-1-git-send-email-jlayton@redhat.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-2" Content-Transfer-Encoding: 7bit Message-Id: <201111282122.53635.rjw@sisk.pl> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday, November 28, 2011, Jeff Layton wrote: > This patchset is a second (third?) attempt at fixing the issues with > suspending a machine that has an active NFS mount. > > The bug reported against Fedora is here: > > https://bugzilla.redhat.com/show_bug.cgi?id=717735 > > The main difference between v2 and this one is that this one has the new > macros attempt to freeze before going to sleep. It's possible for the > freezer_do_not_count() call to race with the freezer. The FREEZER_SKIP > flag can be set after the freezer has already attempted to freeze the > task. If so, it may just go to sleep without attempting to freeze. > > This set attempts to remedy this by calling try_to_freeze() after > calling freezer_do_not_count() and before sleeping. This should prevent > the above race. > > I've also fleshed out the comments a bit to nail down the semantics for > these new functions. I'm quite open to changing the names of the > functions as well, if anyone can suggest better alternatives. > > Comments and more tested would be appreciated. My goal is to get this > in for 3.3, hopefully via Rafael's tree. If no one objects, I'll take these patches to linux-pm/linux-next in the next couple of days (and then to the pm-freezer branch, if there are no visible problems with them). Thanks, Rafael > Jeff Layton (2): > sunrpc: make rpc_wait_bit_killable handle freeze events > nfs: make TASK_KILLABLE sleeps attempt to freeze > > fs/nfs/inode.c | 3 ++- > fs/nfs/nfs3proc.c | 3 ++- > fs/nfs/nfs4proc.c | 5 +++-- > fs/nfs/proc.c | 3 ++- > include/linux/freezer.h | 40 ++++++++++++++++++++++++++++++++++++++++ > net/sunrpc/sched.c | 3 ++- > 6 files changed, 51 insertions(+), 6 deletions(-) > >