mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: Igor Grinberg <grinberg@compulab.co.il>
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>,
	linux-kernel@vger.kernel.org,
	Nicolas Ferre <nicolas.ferre@atmel.com>,
	Grant Likely <grant.likely@secretlab.ca>
Subject: Re: [PATCH 1/2] gpiolib: introduce gpio_set_pullup
Date: Tue, 29 Nov 2011 03:37:08 +0100	[thread overview]
Message-ID: <20111129023708.GN15008@game.jcrosoft.org> (raw)
In-Reply-To: <4ED2045E.7010206@compulab.co.il>

On 11:35 Sun 27 Nov     , Igor Grinberg wrote:
> On 11/25/11 17:34, Mark Brown wrote:
> > On Fri, Nov 25, 2011 at 03:08:39PM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > 
> >> +/**
> >> + * gpio_set_pullup - sets @pullup for a @gpio
> >> + * @gpio: the gpio to set pullup
> >> + * @pullup: pullup level
> >> + */
> >> +int gpio_set_pullup(unsigned gpio, unsigned pullup)
> > 
> > This has some overlap with the pinmux subsystem.  We also need
> > documentation of what the pullup values mean.
yes and no

as some gpio IP (only gpio i2c extender as example ) have it too
so you can not use the pinmux for this
> 
> +1
> 
> AFAIK, 3 values are there: up, down and highz
> Also, IMO, this should have no effect if the GPIO is configured for output.
I see some pio IP have 2 highz

but yes 3 value normaly

Best Regards,
J.

  reply	other threads:[~2011-11-29  2:40 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-25 14:08 Jean-Christophe PLAGNIOL-VILLARD
2011-11-25 14:08 ` [PATCH 2/2] gpiolib: introduce gpio_set_deglitch Jean-Christophe PLAGNIOL-VILLARD
2011-11-25 14:14   ` Felipe Balbi
2011-11-25 15:00     ` Jean-Christophe PLAGNIOL-VILLARD
2011-11-25 14:16 ` [PATCH 1/2] gpiolib: introduce gpio_set_pullup Felipe Balbi
2011-11-25 14:23   ` Jean-Christophe PLAGNIOL-VILLARD
2011-11-25 14:59     ` Felipe Balbi
2011-11-25 15:34 ` Mark Brown
2011-11-27  9:35   ` Igor Grinberg
2011-11-29  2:37     ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2011-11-29 16:51       ` Stephen Warren
2011-12-05 15:40         ` Jean-Christophe PLAGNIOL-VILLARD
2011-12-05 15:56           ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111129023708.GN15008@game.jcrosoft.org \
    --to=plagnioj@jcrosoft.com \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=grant.likely@secretlab.ca \
    --cc=grinberg@compulab.co.il \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nicolas.ferre@atmel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®