From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755325Ab1K2NJT (ORCPT ); Tue, 29 Nov 2011 08:09:19 -0500 Received: from cantor2.suse.de ([195.135.220.15]:57746 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754356Ab1K2NJO (ORCPT ); Tue, 29 Nov 2011 08:09:14 -0500 Date: Tue, 29 Nov 2011 14:09:13 +0100 From: Jan Kara To: Mikulas Patocka Cc: Jan Kara , Valerie Aurora , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, dm-devel@redhat.com, Christopher Chaltain , esandeen@redhat.com, Surbhi Palande Subject: Re: [PATCH] deadlock with suspend and quotas Message-ID: <20111129130913.GE5635@quack.suse.cz> References: <20111128150400.GE6366@quack.suse.cz> <20111129101901.GA5635@quack.suse.cz> <20111129102156.GA7463@quack.suse.cz> <20111129111136.GC5635@quack.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue 29-11-11 07:54:28, Mikulas Patocka wrote: > > > This is technically impossible to achieve on ext2, fat or other > > > non-transactional filesystems. These filesystems have no locks around code > > > paths that set data or inodes dirty. And you still need working sync for > > > ext2. So the best thing to do in sync is to wait until the filesystem is > > > unfrozen. > > Then suspend is effectively unsupported on the filesystem and should > > return EOPNOTSUPP? At least that's what I'd expect... > > LVM uses suspend every time it changes layout of the logical volume. For > example when it converts to/from mirrored format, extends/shrinks the > volume, moves the volume to a different disk, takes a snapshots, merges a > snapshot back, on mirror or multipath failover. > > For most of these actions (except taking a snapshot) it is irrelevant if > there are dirty data in the filesystem cache or not while it is suspended. Hmm, then why do these operations suspend the filesystem if they apparently don't need it? Sorry for my ignorance, I never seriously worked with LVM code... Honza -- Jan Kara SUSE Labs, CR