From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Haogang Chen <haogangchen@gmail.com>
Cc: mchehab@infradead.org, linux-media@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Media: video: uvc: integer overflow in uvc_ioctl_ctrl_map()
Date: Wed, 30 Nov 2011 10:14:41 +0100 [thread overview]
Message-ID: <201111301014.41810.laurent.pinchart@ideasonboard.com> (raw)
In-Reply-To: <CAHrvArQy2N4jUBQpBG+mey9KE412cURK9CU=1xZ_xodA_Vb8Jw@mail.gmail.com>
Hi Haogang,
On Wednesday 30 November 2011 03:28:32 Haogang Chen wrote:
> The hard limit sounds good to me.
OK.
> But if you want to centralize error handling, please make sure that "goto
> done" only frees map, but not map->menu_info in that case.
map->menu_info will be NULL, so it's safe to kfree() it.
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2011-11-30 9:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-29 21:32 Haogang Chen
2011-11-30 1:22 ` Laurent Pinchart
2011-11-30 2:28 ` Haogang Chen
2011-11-30 9:14 ` Laurent Pinchart [this message]
2011-12-11 10:22 ` Mauro Carvalho Chehab
2011-12-11 10:31 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201111301014.41810.laurent.pinchart@ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=haogangchen@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®