From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752384Ab1LAJNJ (ORCPT <rfc822;w@1wt.eu>);
	Thu, 1 Dec 2011 04:13:09 -0500
Received: from mailrelay010.isp.belgacom.be ([195.238.6.177]:38503 "EHLO
	mailrelay010.isp.belgacom.be" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1751712Ab1LAJNH (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 1 Dec 2011 04:13:07 -0500
X-Belgacom-Dynamic: yes
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: Av0EAEtE105R8sT5/2dsb2JhbABEqxCBBoFyAQEEATocIwULCAMOCi4UJQMhE4gHArg0EosOBJRWiQuJCQ
Date: Thu, 1 Dec 2011 10:09:34 +0100
From: Wim Van Sebroeck <wim@iguana.be>
To: Kukjin Kim <kgene.kim@samsung.com>
Cc: "'Thomas Abraham'" <thomas.abraham@linaro.org>,
        "'Dmitry Artamonow'" <mad_soft@inbox.ru>, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        "'Ben Dooks'" <ben-linux@fluff.org>, linux-watchdog@vger.kernel.org
Subject: Re: [PATCH] watchdog: fix initialisation printout in s3c2410_wdt
Message-ID: <20111201090934.GO23376@infomag.iguana.be>
References: <1321433173-17757-1-git-send-email-mad_soft@inbox.ru> <CAJuYYwTv3d9Wg8TDBEkc0r3BweUiLdqVwGdMU4iKpK0B+EM=GA@mail.gmail.com> <045d01ccaffb$00710240$015306c0$%kim@samsung.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <045d01ccaffb$00710240$015306c0$%kim@samsung.com>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Kim,

> Thomas Abraham wrote:
> > 
> > On 16 November 2011 14:16, Dmitry Artamonow <mad_soft@inbox.ru> wrote:
> > > Looks like a typo creeped in, and driver prints
> > > s3c2410-wdt s3c2410-wdt: watchdog active, reset abled, irq abled
> > >
> > > instead of
> > > s3c2410-wdt s3c2410-wdt: watchdog active, reset enabled, irq enabled
> > >
> > > Also it may completely disinform about irq status, as it prints
> > > "irq enabled" when S3C2410_WTCON_INTEN is in fact 0.
> > >
> > > Fix it.
> > >
> > > Signed-off-by: Dmitry Artamonow <mad_soft@inbox.ru>
> > > ---
> > >
> > > It seems to be here for a long time, but I don't think it's
> > > important enough for cc-ing stable.
> > >
> > > Also I haven't tested it, as I don't have a hardware, but it's
> > > rather trivial (and yes, I checked with datasheet that 1 in
> > > S3C2410_WTCON_*EN bits really means 'enabled')
> > >
> > 
> > Tested on Exynos4210 based Origen board. This patch fixed in incorrect
> > "irq enabled" message at bootup. Thanks for this fix.
> > 
> > Tested-by: Thomas Abraham <thomas.abraham@linaro.org>
> > 
> 
> Acked-by: Kukjin Kim <kgene.kim@samsung.com>
> 
> Hi Wim,
> Please pick this up in your tree and if any problem, let me know.

See commit 20403e845f9988446c5b48024ff4d0c3a5929f7d in the linux git tree.

Kind regards,
Wim.