mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Chris Metcalf <cmetcalf@tilera.com>
To: linux-kernel@vger.kernel.org, <linux-pci@vger.kernel.org>,
	<linux-arch@vger.kernel.org>,
	Rolf Eike Beer <eike-kernel@sf-tec.de>,
	Andrew Morton <akpm@linux-foundation.org>,
	"Maxin B. John" <maxin.john@gmail.com>, Tejun Heo <tj@kernel.org>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	"Lucas De Marchi" <lucas.demarchi@profusion.mobi>,
	"Paul Mundt" <lethal@linux-sh.org>,
	"Jesse Barnes" <jbarnes@virtuousgeek.org>,
	"David S. Miller" <davem@davemloft.net>
Subject: [PATCH] lib/devres.c: allow specifying NO_IOPORT while using PCI
Date: Thu, 1 Dec 2011 12:59:19 -0500	[thread overview]
Message-ID: <201112011815.pB1IFGZe004948@farm-0002.internal.tilera.com> (raw)
In-Reply-To: <201111301549.57430.arnd@arndb.de>

The tile architecture does not support IOPORT, but it does support
PCI and IOMEM.  We were not specifying NO_IOPORT, though, because it
was causing a couple of functions (pcim_iomap_regions and pcim_iomap_table)
that are needed to not get provided.  Moving the #ifdef fixes this
so that those functions and some related ones are now always provided
if CONFIG_PCI is true.

Signed-off-by: Chris Metcalf <cmetcalf@tilera.com>
---
This commit was inspired by the recent linux-arch discussion about
what to do with ioport_map on architectures that can't do it, so I went
back to figure out why I hadn't set NO_IOPORT in the first place.
I'm willing to take this into the tile tree if the PCI folks are OK
with it, or if someone else can pick it up, that's fine too.

 arch/tile/Kconfig |    2 +-
 lib/devres.c      |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/tile/Kconfig b/arch/tile/Kconfig
index 70a0de4..e7b1e07 100644
--- a/arch/tile/Kconfig
+++ b/arch/tile/Kconfig
@@ -333,7 +333,7 @@ config NO_IOMEM
 	def_bool !PCI
 
 config NO_IOPORT
-	def_bool !PCI
+	def_bool y
 
 source "drivers/pci/Kconfig"
 
diff --git a/lib/devres.c b/lib/devres.c
index 7c0e953..5f36cfd 100644
--- a/lib/devres.c
+++ b/lib/devres.c
@@ -144,6 +144,7 @@ void devm_ioport_unmap(struct device *dev, void __iomem *addr)
 			       devm_ioport_map_match, (void *)addr));
 }
 EXPORT_SYMBOL(devm_ioport_unmap);
+#endif
 
 #ifdef CONFIG_PCI
 /*
@@ -349,4 +350,3 @@ void pcim_iounmap_regions(struct pci_dev *pdev, u16 mask)
 }
 EXPORT_SYMBOL(pcim_iounmap_regions);
 #endif
-#endif
-- 
1.6.5.2


  parent reply	other threads:[~2011-12-01 18:18 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-29 18:54 [PATCH-RFC 0/2] tile: switch to generic pci_iomap Michael S. Tsirkin
2011-11-29 18:54 ` [PATCH-RFC 1/2] tile: don't panic on iomap Michael S. Tsirkin
2011-11-29 21:04   ` Bjorn Helgaas
2011-11-30  7:04     ` Michael S. Tsirkin
2011-11-29 22:05   ` Arnd Bergmann
2011-11-30  7:13     ` Michael S. Tsirkin
2011-11-30  9:09       ` Arnd Bergmann
2011-11-30 11:59         ` Michael S. Tsirkin
2011-11-30 14:04           ` Arnd Bergmann
2011-11-30 14:31             ` Michael S. Tsirkin
2011-11-30 15:49               ` Arnd Bergmann
2011-11-30 15:59                 ` Michael S. Tsirkin
2011-11-30 18:32                   ` Arnd Bergmann
2011-12-01 17:59                 ` Chris Metcalf [this message]
2011-12-01 18:44                   ` [PATCH] lib/devres.c: allow specifying NO_IOPORT while using PCI Tejun Heo
2011-12-01 18:48                     ` Chris Metcalf
2011-12-01 22:47                   ` Arnd Bergmann
2011-12-02 18:48                     ` Chris Metcalf
2011-12-05 15:14                       ` Arnd Bergmann
2011-12-05 20:08                         ` Chris Metcalf
2011-11-30  9:08   ` [PATCH-RFC 1/2 v2] tile: don't panic on iomap Michael S. Tsirkin
2011-11-29 18:54 ` [PATCH-RFC 2/2] tile: switch to GENERIC_PCI_IOMAP Michael S. Tsirkin
2011-11-30 21:19   ` Chris Metcalf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201112011815.pB1IFGZe004948@farm-0002.internal.tilera.com \
    --to=cmetcalf@tilera.com \
    --cc=akpm@linux-foundation.org \
    --cc=davem@davemloft.net \
    --cc=eike-kernel@sf-tec.de \
    --cc=jbarnes@virtuousgeek.org \
    --cc=lethal@linux-sh.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lucas.demarchi@profusion.mobi \
    --cc=maxin.john@gmail.com \
    --cc=mst@redhat.com \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®