From: Ingo Molnar <mingo@elte.hu>
To: David Rientjes <rientjes@google.com>
Cc: tglx@linutronix.de, Ingo Molnar <mingo@redhat.com>,
"H. Peter Anvin" <hpa@zytor.com>,
H Hartley Sweeten <hartleys@visionengravers.com>,
linux-kernel@vger.kernel.org, x86@kernel.org,
Yinghai Lu <yinghai.lu@oracle.com>, Tejun Heo <htejun@gmail.com>
Subject: Re: [PATCH] x86: use the same node_distance for 32 and 64-bit
Date: Mon, 5 Dec 2011 13:44:49 +0100 [thread overview]
Message-ID: <20111205124449.GG3143@elte.hu> (raw)
In-Reply-To: <alpine.DEB.2.00.1110141325010.24783@chino.kir.corp.google.com>
* David Rientjes <rientjes@google.com> wrote:
> On Mon, 19 Sep 2011, David Rientjes wrote:
>
> > On Mon, 19 Sep 2011, H Hartley Sweeten wrote:
> >
> > > The node_distance function is not x86 64-bit specific. Having the #ifdef
> > > around the extern function declaration and the #define causes the default
> > > node_distance macro to be used in asm-generic/topology.h. This also causes
> > > a sparse warning in arch/x86/mm/numa.c when CONFIG_X86_64 is not set:
> > >
> > > warning: symbol '__node_distance' was not declared. Should it be static?
> > >
> > > Remove the #ifdef to fix both issues.
> > >
> > > Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
> > > Cc: Thomas Gleixner <tglx@linutronix.de>
> > > Cc: Ingo Molnar <mingo@redhat.com>
> > > Cc: "H. Peter Anvin" <hpa@zytor.com>
> > > Cc: Tejun Heo <tj@kernel.org>
> > > Cc: Yinghai Lu <yinghai@kernel.org>
> >
> > [ I think kernel.org emails are still down, so I sent this to
> > htejun@gmail.com instead. ]
> >
> > Acked-by: David Rientjes <rientjes@google.com>
> >
>
> Ingo, Peter, I don't think this was merged into any x86 tree
> yet (and I gave up trying to figure it out, cloning from
> tesla.tglx.de was going about 2kB/sec).
>
> It was also acked by Tejun Heo <tj@kernel.org> during review.
No objections, could someone please resend it with all acks in
place, and with maintainers Cc:-ed? I don't have the original
mail in any of my folders.
Thanks,
Ingo
next prev parent reply other threads:[~2011-12-05 12:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-19 23:03 H Hartley Sweeten
2011-09-20 0:51 ` David Rientjes
2011-10-14 20:27 ` David Rientjes
2011-12-05 12:44 ` Ingo Molnar [this message]
2011-12-06 20:22 ` [patch resend] " David Rientjes
2011-12-07 8:58 ` [tip:x86/asm] x86: Use " tip-bot for H Hartley Sweeten
2011-09-24 1:45 ` [PATCH] x86: use " Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111205124449.GG3143@elte.hu \
--to=mingo@elte.hu \
--cc=hartleys@visionengravers.com \
--cc=hpa@zytor.com \
--cc=htejun@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rientjes@google.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=yinghai.lu@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome