mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Stanislaw Gruszka <sgruszka@redhat.com>,
	x86@kernel.org, linux-kernel@vger.kernel.org,
	Mathias Nyman <mathias.nyman@linux.intel.com>
Subject: Re: [PATCH -tip] x86: fix build without CONFIG_X86_MRST
Date: Tue, 6 Dec 2011 11:31:03 +0100	[thread overview]
Message-ID: <20111206103103.GC15966@elte.hu> (raw)
In-Reply-To: <20111206103022.434ebf6f@lxorguk.ukuu.org.uk>


* Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:

> On Tue,  6 Dec 2011 11:18:22 +0100
> Stanislaw Gruszka <sgruszka@redhat.com> wrote:
> 
> > Fix compilation error when compiled with CONFIG_X86_INTEL_MID and
> > without CONFIG_X86_MRST:
> > 
> > arch/x86/built-in.o: In function `add_rtc_cmos':
> > rtc.c:(.init.text+0x34bd): undefined reference to `__mrst_cpu_chip'
> 
> It really is INTEL_MID wide, but there were other problems 
> with the way the INTEL_MID selection was done. Should be fixed 
> with the patch I sent Ingo.

Hm, i didnt realize that it broke the build upstream as well. I 
improved your changelog to indicate the build failure and also 
cherry-picked it over from tip:x86/platform (v3.3 material) into 
tip:x86/urgent (v3.2 fixes).

Thanks,

	Ingo

  reply	other threads:[~2011-12-06 10:32 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-06 10:18 Stanislaw Gruszka
2011-12-06 10:30 ` Alan Cox
2011-12-06 10:31   ` Ingo Molnar [this message]
2011-12-06 13:17     ` Alan Cox
2011-12-06 17:12       ` Ingo Molnar
2011-12-12 18:33         ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111206103103.GC15966@elte.hu \
    --to=mingo@elte.hu \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathias.nyman@linux.intel.com \
    --cc=sgruszka@redhat.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome