mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Neil Horman <nhorman@tuxdriver.com>
To: Weiping Pan <panweiping3@gmail.com>
Cc: shanwei88@gmail.com, Randy Dunlap <rdunlap@xenotime.net>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <eric.dumazet@gmail.com>,
	Shan Wei <shanwei@cn.fujitsu.com>, Max Matveev <makc@redhat.com>,
	"open list:DOCUMENTATION" <linux-doc@vger.kernel.org>,
	open list <linux-kernel@vger.kernel.org>,
	"open list:NETWORKING [GENERAL]" <netdev@vger.kernel.org>
Subject: Re: [PATCH V2 net] ipv4:correct description for tcp_max_syn_backlog
Date: Tue, 6 Dec 2011 09:07:09 -0500	[thread overview]
Message-ID: <20111206140709.GA29082@hmsreliant.think-freely.org> (raw)
In-Reply-To: <ed04712f4f61e291ac784a8a77e2831981cfb9c1.1323156956.git.panweiping3@gmail.com>

On Tue, Dec 06, 2011 at 03:39:41PM +0800, Weiping Pan wrote:
> Since commit c5ed63d66f24(tcp: fix three tcp sysctls tuning),
> sysctl_max_syn_backlog is determined by tcp_hashinfo->ehash_mask,
> and the minimal value is 128, and it will increase in proportion to the
> memory of machine.
> The original description for tcp_max_syn_backlog and sysctl_max_syn_backlog
> are out of date.
> 
> Changelog:
> V2: update description for sysctl_max_syn_backlog
> 
> Signed-off-by: Weiping Pan <panweiping3@gmail.com>
> ---
>  Documentation/networking/ip-sysctl.txt |   10 +++++-----
>  net/core/request_sock.c                |    7 ++++---
>  2 files changed, 9 insertions(+), 8 deletions(-)
> 
> diff --git a/Documentation/networking/ip-sysctl.txt b/Documentation/networking/ip-sysctl.txt
> index f049a1c..589f2da 100644
> --- a/Documentation/networking/ip-sysctl.txt
> +++ b/Documentation/networking/ip-sysctl.txt
> @@ -282,11 +282,11 @@ tcp_max_ssthresh - INTEGER
>  	Default: 0 (off)
>  
>  tcp_max_syn_backlog - INTEGER
> -	Maximal number of remembered connection requests, which are
> -	still did not receive an acknowledgment from connecting client.
> -	Default value is 1024 for systems with more than 128Mb of memory,
> -	and 128 for low memory machines. If server suffers of overload,
> -	try to increase this number.
> +	Maximal number of remembered connection requests, which have not
> +	received an acknowledgment from connecting client.
> +	The minimal value is 128 for low memory machines, and it will
> +	increase in proportion to the memory of machine.
> +	If server suffers from overload, try increasing this number.
>  
>  tcp_max_tw_buckets - INTEGER
>  	Maximal number of timewait sockets held by system simultaneously.
> diff --git a/net/core/request_sock.c b/net/core/request_sock.c
> index 182236b..9b570a6 100644
> --- a/net/core/request_sock.c
> +++ b/net/core/request_sock.c
> @@ -26,10 +26,11 @@
>   * but then some measure against one socket starving all other sockets
>   * would be needed.
>   *
> - * It was 128 by default. Experiments with real servers show, that
> + * The minimum value of it is 128. Experiments with real servers show that
>   * it is absolutely not enough even at 100conn/sec. 256 cures most
> - * of problems. This value is adjusted to 128 for very small machines
> - * (<=32Mb of memory) and to 1024 on normal or better ones (>=256Mb).
> + * of problems.
> + * This value is adjusted to 128 for low memory machines,
> + * and it will increase in proportion to the memory of machine.
>   * Note : Dont forget somaxconn that may limit backlog too.
>   */
>  int sysctl_max_syn_backlog = 256;
> -- 
> 1.7.4.4
> 
> 
Acked-by: Neil Horman <nhorman@tuxdriver.com>


  reply	other threads:[~2011-12-06 14:07 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <4EDDC1D6.6000708@gmail.com>
2011-12-06  7:39 ` Weiping Pan
2011-12-06 14:07   ` Neil Horman [this message]
2011-12-06 18:02     ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111206140709.GA29082@hmsreliant.think-freely.org \
    --to=nhorman@tuxdriver.com \
    --cc=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=makc@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=panweiping3@gmail.com \
    --cc=rdunlap@xenotime.net \
    --cc=shanwei88@gmail.com \
    --cc=shanwei@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®