mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Nick Bowler <nbowler@elliptictech.com>
Cc: Ben Hutchings <ben@decadent.org.uk>,
	mingo@redhat.com, hpa@zytor.com, linux-kernel@vger.kernel.org,
	a.p.zijlstra@chello.nl, tglx@linutronix.de,
	linux-tip-commits@vger.kernel.org
Subject: Re: [tip:core/locking] lockdep, rtmutex, bug: Show taint flags on error
Date: Tue, 6 Dec 2011 19:20:35 +0100	[thread overview]
Message-ID: <20111206182035.GA12094@elte.hu> (raw)
In-Reply-To: <20111206181422.GA11881@elliptictech.com>


* Nick Bowler <nbowler@elliptictech.com> wrote:

> > Your original patch did two things. Peter did the sensible 
> > thing: he split out the print_kernel_ident() changes from 
> > your patch which stand on their own and kept your authorship 
> > in place - that is what the above patch does.
> 
> In which case, the changelog should have been amended to state 
> that it's a modification of Ben's original submission.

Which is what i said in my reply to Alan:

 | What Peter probably could have done is to add one more line
 | before his SOB:
 |
 |   [ split out the patch from the original submission ]
 |   Signed-off-by: Peter Zijlstra <peterz@infradead.org>
 |
 | Otherwise Ben Hutchings's objection here makes little sense.

No line of code was added by Peter - it's all Ben's changes.

Note that the commit in question:

  fbdc4b9a6c29: lockdep, rtmutex, bug: Show taint flags on error

is actually a good one and i think even Ben actually thinks 
those changes are good. Nothing was added - Ben only wants 
*more* to be done in a single patch and is being silly about the 
SOB and is asking it to be removed.

Thanks,

	Ingo

  reply	other threads:[~2011-12-06 18:22 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-28  3:36 [PATCH 1/2] lockdep,rtmutex,bug: " Ben Hutchings
2011-10-31  1:59 ` Rusty Russell
2011-11-16 21:52 ` Ben Hutchings
2011-11-16 22:24   ` Dave Jones
2011-11-17  8:48   ` Peter Zijlstra
2011-11-17 15:18     ` Ben Hutchings
2011-12-06  9:38 ` [tip:core/locking] lockdep, rtmutex, bug: " tip-bot for Ben Hutchings
2011-12-06 15:34   ` Ben Hutchings
2011-12-06 17:48     ` Peter Zijlstra
2011-12-06 17:55       ` Alan Cox
2011-12-06 17:56         ` Peter Zijlstra
2011-12-06 17:59         ` Ingo Molnar
2011-12-06 18:17           ` Ben Hutchings
2011-12-06 18:28             ` Ingo Molnar
2011-12-06 19:14               ` Ingo Molnar
2011-12-06 21:13                 ` Ben Hutchings
2011-12-07  7:49                   ` Ingo Molnar
2011-12-06 18:04         ` Ingo Molnar
2011-12-06 17:54     ` Ingo Molnar
2011-12-06 18:14       ` Nick Bowler
2011-12-06 18:20         ` Ingo Molnar [this message]
2011-12-06 18:21         ` Alan Cox
2011-12-06 18:34           ` Ingo Molnar
2011-12-06 18:23         ` Ben Hutchings

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111206182035.GA12094@elte.hu \
    --to=mingo@elte.hu \
    --cc=a.p.zijlstra@chello.nl \
    --cc=ben@decadent.org.uk \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=nbowler@elliptictech.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome