From: Will Deacon <will.deacon@arm.com>
To: Jon Masters <jcm@redhat.com>
Cc: mhban <mhban@samsung.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
DavidHowells <dhowells@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
Michel Lespinasse <walken@google.com>,
Russell King <linux@arm.linux.org.uk>,
Chris Metcalf <cmetcalf@tilera.com>
Subject: Re: [PATCH] ARM: futex: fix clobbering oldval
Date: Tue, 6 Dec 2011 19:11:09 +0000 [thread overview]
Message-ID: <20111206191109.GB5385@mudshark.cambridge.arm.com> (raw)
In-Reply-To: <1323197914.11696.30.camel@constitution.bos.jonmasters.org>
Hi Jon,
On Tue, Dec 06, 2011 at 06:58:34PM +0000, Jon Masters wrote:
> On Thu, 2011-09-22 at 18:26 +0100, Will Deacon wrote:
> > Hi,
> >
> > On Thu, Sep 22, 2011 at 03:53:35AM +0100, mhban wrote:
> > > This patch fixes clobbering oldval bug. oldval should be preserved for next
> > > compare operation.
> > >
> > > Change-Id: I2a63bc1bdb8de330eb9e1ac02d7da1f77e6e8c3c
> > > Signed-off-by: Minho Ban <mhban@samsung.com>
> >
> > It would have been nice to have been CC'd on this...
> >
> > I ran LTP tests on this, so I'm surprised that this was broken (the tests
> > passed). Well spotted anyway!
>
> This appears to be the cause of our "stuck builder" problem in Fedora
> building certain large packages, such as OpenJDK. Some of our guys are
> still monitoring the situation in case there's a secondary issue.
>
> Was there ever any additional followup on this topic?
Yup, check commit df77abca ("ARM: 7099/1: futex: preserve oldval in SMP
__futex_atomic_op"). It should be in stable for all affected kernels too.
Cheers,
Will
next prev parent reply other threads:[~2011-12-06 19:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-22 2:53 mhban
2011-09-22 17:26 ` Will Deacon
2011-09-23 0:18 ` mhban
2011-09-23 8:43 ` Will Deacon
2011-12-06 18:58 ` Jon Masters
2011-12-06 19:11 ` Will Deacon [this message]
2011-12-06 19:38 ` Jon Masters
2011-12-06 21:14 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111206191109.GB5385@mudshark.cambridge.arm.com \
--to=will.deacon@arm.com \
--cc=cmetcalf@tilera.com \
--cc=dhowells@redhat.com \
--cc=jcm@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mhban@samsung.com \
--cc=tglx@linutronix.de \
--cc=walken@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®