From: Shawn Guo <shawn.guo@freescale.com>
To: "Lothar Waßmann" <LW@KARO-electronics.de>
Cc: <netdev@vger.kernel.org>, Shawn Guo <shawn.guo@linaro.org>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH][NET] several cleanups and bugfixes for fec.c: don't munge MAC address from platform data
Date: Wed, 7 Dec 2011 16:49:54 +0800 [thread overview]
Message-ID: <20111207084953.GD5550@S2100-06.ap.freescale.net> (raw)
In-Reply-To: <55b78c1766da5b0d0d679f5eae3fb9fc74a6ceef.1323163127.git.LW@KARO-electronics.de>
On Tue, Dec 06, 2011 at 11:27:13AM +0100, Lothar Waßmann wrote:
> When the MAC address is supplied via platform_data it should be OK as
> it is and should not be modified in case of a dual FEC setup.
> Also copying the MAC from platform_data to the single 'macaddr'
> variable will overwrite the MAC for the first interface in case of a
> dual FEC setup.
Hmm, I do not follow that. If 'macaddr' holds a valid mac address,
the code path has no chance to be hit at all. Otherwise, 'macaddr'
is just a place holder for copying mac address from pdata, in which
case the mac address will be fixed up at the end of the function for
dual FEC setup.
Regards,
Shawn
>
> Signed-off-by: Lothar Waßmann <LW@KARO-electronics.de>
> ---
> drivers/net/ethernet/freescale/fec.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/ethernet/freescale/fec.c b/drivers/net/ethernet/freescale/fec.c
> index e2b5ce6..11534b9 100644
> --- a/drivers/net/ethernet/freescale/fec.c
> +++ b/drivers/net/ethernet/freescale/fec.c
> @@ -818,7 +818,7 @@ static void __inline__ fec_get_mac(struct net_device *ndev)
> iap = (unsigned char *)FEC_FLASHMAC;
> #else
> if (pdata)
> - memcpy(iap, pdata->mac, ETH_ALEN);
> + iap = (unsigned char *)&pdata->mac;
> #endif
> }
>
> --
> 1.5.6.5
next prev parent reply other threads:[~2011-12-07 8:37 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-06 10:27 [PATCH][NET] several cleanups and bugfixes for fec.c Lothar Waßmann
2011-12-06 10:27 ` [PATCH][NET] several cleanups and bugfixes for fec.c: misc cleanups Lothar Waßmann
2011-12-06 10:27 ` [PATCH][NET] several cleanups and bugfixes for fec.c: set con_id in clk_get() call to NULL Lothar Waßmann
2011-12-06 10:27 ` [PATCH][NET] several cleanups and bugfixes for fec.c: prevent dobule restart of interface on FDX/HDX change Lothar Waßmann
2011-12-06 10:27 ` [PATCH][NET] several cleanups and bugfixes for fec.c: don't request invalid IRQ Lothar Waßmann
2011-12-06 10:27 ` [PATCH][NET] several cleanups and bugfixes for fec.c: don't munge MAC address from platform data Lothar Waßmann
2011-12-06 10:27 ` [PATCH][NET] several cleanups and bugfixes for fec.c: preserve MII/RMII setting in fec_stop() Lothar Waßmann
2011-12-06 10:27 ` [PATCH][NET] several cleanups and bugfixes for fec.c: fix the .remove code Lothar Waßmann
2011-12-06 10:27 ` [PATCH][NET] several cleanups and bugfixes for fec.c: make FEC driver buildable as module Lothar Waßmann
2011-12-07 13:28 ` [PATCH][NET] several cleanups and bugfixes for fec.c: fix the .remove code Shawn Guo
2011-12-07 13:26 ` Lothar Waßmann
2011-12-07 13:43 ` Shawn Guo
2011-12-07 9:41 ` [PATCH][NET] several cleanups and bugfixes for fec.c: preserve MII/RMII setting in fec_stop() Shawn Guo
2011-12-07 10:42 ` Lothar Waßmann
2011-12-07 10:58 ` Shawn Guo
2011-12-07 10:49 ` Lothar Waßmann
2011-12-07 11:15 ` Shawn Guo
2011-12-07 13:37 ` Shawn Guo
2011-12-06 12:48 ` [PATCH][NET] several cleanups and bugfixes for fec.c: don't munge MAC address from platform data Baruch Siach
2011-12-06 13:44 ` Lothar Waßmann
2011-12-07 8:57 ` Shawn Guo
2011-12-07 8:47 ` Lothar Waßmann
2011-12-07 8:49 ` Shawn Guo [this message]
2011-12-07 8:47 ` Lothar Waßmann
2011-12-07 9:14 ` Shawn Guo
2011-12-07 8:27 ` [PATCH][NET] several cleanups and bugfixes for fec.c: don't request invalid IRQ Shawn Guo
2011-12-06 15:24 ` [PATCH][NET] several cleanups and bugfixes for fec.c: prevent dobule restart of interface on FDX/HDX change Ben Hutchings
2011-12-07 8:26 ` [PATCH][NET] several cleanups and bugfixes for fec.c: set con_id in clk_get() call to NULL Shawn Guo
2011-12-07 8:25 ` [PATCH][NET] several cleanups and bugfixes for fec.c: misc cleanups Shawn Guo
2011-12-06 18:17 ` [PATCH][NET] several cleanups and bugfixes for fec.c David Miller
2011-12-29 6:38 ` Dirk Behme
2011-12-29 7:14 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111207084953.GD5550@S2100-06.ap.freescale.net \
--to=shawn.guo@freescale.com \
--cc=LW@KARO-electronics.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®