From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755839Ab1LGNa6 (ORCPT ); Wed, 7 Dec 2011 08:30:58 -0500 Received: from va3ehsobe001.messaging.microsoft.com ([216.32.180.11]:49454 "EHLO VA3EHSOBE008.bigfish.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755357Ab1LGNa5 convert rfc822-to-8bit (ORCPT ); Wed, 7 Dec 2011 08:30:57 -0500 X-SpamScore: -5 X-BigFish: VS-5(z37d4lzc89bh1432N98dKzz1202hzz8275dhz2dh2a8h668h839h62h) X-Spam-TCS-SCL: 1:0 X-Forefront-Antispam-Report: CIP:70.37.183.190;KIP:(null);UIP:(null);IPV:NLI;H:mail.freescale.net;RD:none;EFVD:NLI Date: Wed, 7 Dec 2011 21:43:36 +0800 From: Shawn Guo To: Lothar =?iso-8859-1?Q?Wa=DFmann?= CC: , Shawn Guo , , Subject: Re: [PATCH][NET] several cleanups and bugfixes for fec.c: fix the .remove code Message-ID: <20111207134336.GS5550@S2100-06.ap.freescale.net> References: <04c11563fee748562d7b53d5e5b3c5cf37fef200.1323163127.git.LW@KARO-electronics.de> <20111207132828.GQ5550@S2100-06.ap.freescale.net> <20191.27018.478290.890636@ipc1.ka-ro> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline In-Reply-To: <20191.27018.478290.890636@ipc1.ka-ro> User-Agent: Mutt/1.5.21 (2010-09-15) Content-Transfer-Encoding: 8BIT X-OriginatorOrg: freescale.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 07, 2011 at 02:26:34PM +0100, Lothar Waßmann wrote: > Hi, > > Shawn Guo writes: > > On Tue, Dec 06, 2011 at 11:27:15AM +0100, Lothar Waßmann wrote: > > > The .remove code is broken in several ways. > > > - mdiobus_unregister() is called twice for the same object in case of dual FEC > > > - phy_disconnect() is being called when the PHY is already disconnected > > > - the requested IRQ(s) are not freed > > > - fec_stop() is being called with the inteface already stopped > > > > > > All of those lead to kernel crashes if the remove function is actually used. > > > > > > Signed-off-by: Lothar Waßmann > > > --- > > > drivers/net/ethernet/freescale/fec.c | 30 +++++++++++++++++++++--------- > > > 1 files changed, 21 insertions(+), 9 deletions(-) > > > > > > diff --git a/drivers/net/ethernet/freescale/fec.c b/drivers/net/ethernet/freescale/fec.c > > > index ab0afb5..70ec7ec 100644 > > > --- a/drivers/net/ethernet/freescale/fec.c > > > +++ b/drivers/net/ethernet/freescale/fec.c > > > @@ -235,6 +235,7 @@ struct fec_enet_private { > > > > > > /* Phylib and MDIO interface */ > > > struct mii_bus *mii_bus; > > > + int mii_cnt; > > > struct phy_device *phy_dev; > > > int mii_timeout; > > > uint phy_speed; > > > @@ -1040,8 +1041,12 @@ static int fec_enet_mii_init(struct platform_device *pdev) > > > */ > > > if ((id_entry->driver_data & FEC_QUIRK_ENET_MAC) && pdev->id > 0) { > > > /* fec1 uses fec0 mii_bus */ > > > - fep->mii_bus = fec0_mii_bus; > > > - return 0; > > > + if (fep->mii_cnt && fec0_mii_bus) { > > > > This seems broken. The second fec has its own fep and fep->mii_cnt is > > always 0 here. > > > I already noticed that myself. > With a quick fix here, the last two patches: Tested-by: Shawn Guo -- Regards, Shawn