From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752628Ab1LHJEW (ORCPT ); Thu, 8 Dec 2011 04:04:22 -0500 Received: from am1ehsobe003.messaging.microsoft.com ([213.199.154.206]:8893 "EHLO AM1EHSOBE003.bigfish.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750716Ab1LHJEQ convert rfc822-to-8bit (ORCPT ); Thu, 8 Dec 2011 04:04:16 -0500 X-SpamScore: -9 X-BigFish: VS-9(zzc89bh1432N98dKzz1202hzz8275dhz2dh2a8h668h839h) X-Forefront-Antispam-Report: CIP:70.37.183.190;KIP:(null);UIP:(null);IPV:NLI;H:mail.freescale.net;RD:none;EFVD:NLI Date: Thu, 8 Dec 2011 17:17:02 +0800 From: Shawn Guo To: Lothar =?iso-8859-1?Q?Wa=DFmann?= CC: Shawn Guo , Sascha Hauer , , , , Chris Ball Subject: Re: [MXS MMC v2 2/4] Some cleanups for the MMC driver Message-ID: <20111208091701.GC7913@S2100-06.ap.freescale.net> References: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Content-Transfer-Encoding: 8BIT X-OriginatorOrg: freescale.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 08, 2011 at 09:17:45AM +0100, Lothar Waßmann wrote: > - Remove bogus parens around numerical arguments in #define's > - When defining bit masks, use the #def for the shift count > instead of repeating the numbers > - Remove 'break' at end of switch statement > > Changes wrt v1: > - break long lines > - leave indentation as is > > Signed-off-by: Lothar Waßmann Acked-by: Shawn Guo Not sure if Chris will ask you to add proper subject prefix though :) -- Regards, Shawn