From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: "Ohad Ben-Cohen" <ohad@wizery.com>
Cc: Dmitry Artamonow <mad_soft@inbox.ru>,
linux-kernel@vger.kernel.org,
Mauro Carvalho Chehab <mchehab@infradead.org>,
linux-media@vger.kernel.org
Subject: Re: [PATCH] [media] omap3isp: fix compilation of ispvideo.c
Date: Thu, 8 Dec 2011 10:53:59 +0100 [thread overview]
Message-ID: <201112081054.01240.laurent.pinchart@ideasonboard.com> (raw)
In-Reply-To: <CADMYwHzPJeu6ixNJ=uRVEF-wz7Uz4oYdfHme8g1sRAK20Cro0w@mail.gmail.com>
Hi Ohad,
On Thursday 08 December 2011 07:31:29 Ohad Ben-Cohen wrote:
> On Wed, Nov 23, 2011 at 3:53 AM, Laurent Pinchart wrote:
> > On Sunday 20 November 2011 17:54:26 Dmitry Artamonow wrote:
> >> Fix following build error by explicitely including <linux/module.h>
> >> header file.
> >>
> >> CC drivers/media/video/omap3isp/ispvideo.o
> >> drivers/media/video/omap3isp/ispvideo.c:1267: error: 'THIS_MODULE'
> >> undeclared here (not in a function) make[4]: ***
> >> [drivers/media/video/omap3isp/ispvideo.o] Error 1
> >> make[3]: *** [drivers/media/video/omap3isp] Error 2
> >> make[2]: *** [drivers/media/video] Error 2
> >> make[1]: *** [drivers/media] Error 2
> >> make: *** [drivers] Error 2
> >>
> >> Signed-off-by: Dmitry Artamonow <mad_soft@inbox.ru>
> >
> > Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> >
> > Mauro, can you pick this for v3.2, or would you like me to send a pull
> > request ?
>
> Folks, was this one picked up by anyone ?
>
> We seem to still have this issue in mainline (at least in rc4).
According to http://patchwork.linuxtv.org/patch/8510/ the patch has been
accepted. Mauro, do you have any time estimate regarding when you will push
that to Linus ?
--
Regards,
Laurent Pinchart
prev parent reply other threads:[~2011-12-08 9:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-20 16:54 Dmitry Artamonow
2011-11-23 1:53 ` Laurent Pinchart
2011-12-08 6:31 ` Ohad Ben-Cohen
2011-12-08 9:53 ` Laurent Pinchart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201112081054.01240.laurent.pinchart@ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mad_soft@inbox.ru \
--cc=mchehab@infradead.org \
--cc=ohad@wizery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®