From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754601Ab1LITKZ (ORCPT ); Fri, 9 Dec 2011 14:10:25 -0500 Received: from earthlight.etchedpixels.co.uk ([81.2.110.250]:36282 "EHLO pyramind.ukuu.org.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752153Ab1LITKX (ORCPT ); Fri, 9 Dec 2011 14:10:23 -0500 Date: Fri, 9 Dec 2011 19:10:32 +0000 From: Alan Cox To: Wolfram Sang Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, Greg KH , Alan Cox , Claudio Scordino Subject: Re: [PATCH RESEND 3/8] serial: 8250: save rs485_flags per instance Message-ID: <20111209191032.76bff8e8@pyramind.ukuu.org.uk> In-Reply-To: <1323450440-414-4-git-send-email-w.sang@pengutronix.de> References: <1323450440-414-1-git-send-email-w.sang@pengutronix.de> <1323450440-414-4-git-send-email-w.sang@pengutronix.de> X-Mailer: Claws Mail 3.7.10 (GTK+ 2.24.8; x86_64-redhat-linux-gnu) Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAFVBMVEWysKsSBQMIAwIZCwj///8wIhxoRDXH9QHCAAABeUlEQVQ4jaXTvW7DIBAAYCQTzz2hdq+rdg494ZmBeE5KYHZjm/d/hJ6NfzBJpp5kRb5PHJwvMPMk2L9As5Y9AmYRBL+HAyJKeOU5aHRhsAAvORQ+UEgAvgddj/lwAXndw2laEDqA4x6KEBhjYRCg9tBFCOuJFxg2OKegbWjbsRTk8PPhKPD7HcRxB7cqhgBRp9Dcqs+B8v4CQvFdqeot3Kov6hBUn0AJitrzY+sgUuiA8i0r7+B3AfqKcN6t8M6HtqQ+AOoELCikgQSbgabKaJW3kn5lBs47JSGDhhLKDUh1UMipwwinMYPTBuIBjEclSaGZUk9hDlTb5sUTYN2SFFQuPe4Gox1X0FZOufjgBiV1Vls7b+GvK3SU4wfmcGo9rPPQzgIabfj4TYQo15k3bTHX9RIw/kniir5YbtJF4jkFG+dsDK1IgE413zAthU/vR2HVMmFUPIHTvF6jWCpFaGw/A3qWgnbxpSm9MSmY5b3pM1gvNc/gQfwBsGwF0VCtxZgAAAAASUVORK5CYII= Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 9 Dec 2011 18:07:15 +0100 Wolfram Sang wrote: > When set, save RS485 related flags in the private struct. This avoids > mangling with chip registers when reading back the RS485 config. Also, > features can check their configuration at runtime which will be needed > for a later patch. Ok thats what I get for reading in order - so the #2 problem is ok when its folded together