From: Ingo Molnar <mingo@elte.hu>
To: Borislav Petkov <bp@amd64.org>
Cc: X86-ML <x86@kernel.org>, LKML <linux-kernel@vger.kernel.org>,
Borislav Petkov <borislav.petkov@amd.com>
Subject: Re: [PATCH 0/5] x86, microcode, AMD: Size checking fixes
Date: Mon, 12 Dec 2011 18:34:31 +0100 [thread overview]
Message-ID: <20111212173430.GJ23870@elte.hu> (raw)
In-Reply-To: <1323454135-16777-1-git-send-email-bp@amd64.org>
* Borislav Petkov <bp@amd64.org> wrote:
> From: Borislav Petkov <borislav.petkov@amd.com>
>
> Hi all,
>
> this is a patchset that reworks and fixes ucode size checking.
> The meat of it is contained in 3/5 which reworks the code to
> iterate over the patches in the microcode binary image
> _without_ vmalloc-ing space for every patch in succession in
> order to look at it and go on to the next, if it doesn't fit.
>
> In any case, we end up loading at most one patch so before we
> copy it in local storage we do all possible checks on it now,
> and copy it only then, if all checks are passed.
>
> Also, for simplicity, we alloc a single 4K page as a buffer
> for it which we keep per CPU as long as the ucode module is
> loaded and free upon exit. This simplifies all
> allocations/cleanup paths significantly.
No objections from anyone it appears - did you want to send this
as a pull request?
Thanks,
Ingo
next prev parent reply other threads:[~2011-12-12 17:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-09 18:08 Borislav Petkov
2011-12-09 18:08 ` [PATCH 1/5] x86, microcode, AMD: Add a vendor-specific exit function Borislav Petkov
2011-12-09 18:08 ` [PATCH 2/5] x86, microcode, AMD: Add a reusable buffer Borislav Petkov
2011-12-09 18:08 ` [PATCH 3/5] x86, microcode, AMD: Simplify ucode verification Borislav Petkov
2011-12-09 18:08 ` [PATCH 4/5] x86, microcode, AMD: Exit early on success Borislav Petkov
2011-12-09 18:08 ` [PATCH 5/5] x86, microcode, AMD: Update copyrights Borislav Petkov
2011-12-12 17:34 ` Ingo Molnar [this message]
2011-12-12 20:51 ` [PATCH 0/5] x86, microcode, AMD: Size checking fixes Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111212173430.GJ23870@elte.hu \
--to=mingo@elte.hu \
--cc=borislav.petkov@amd.com \
--cc=bp@amd64.org \
--cc=linux-kernel@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®