From: Samuel Ortiz <sameo@linux.intel.com>
To: Donggeun Kim <dg77.kim@samsung.com>
Cc: linux-kernel@vger.kernel.org, rpurdie@rpsys.net,
broonie@opensource.wolfsonmicro.com, myungjoo.ham@samsung.com,
kyungmin.park@samsung.com
Subject: Re: [PATCH RESEND 1/2] MFD: MAX8997: add platform data and devices for LED control
Date: Tue, 13 Dec 2011 21:59:05 +0100 [thread overview]
Message-ID: <20111213205905.GH2796@sortiz-mobl> (raw)
In-Reply-To: <1323764033-3979-2-git-send-email-dg77.kim@samsung.com>
Hi Donggeun,
On Tue, Dec 13, 2011 at 05:13:52PM +0900, Donggeun Kim wrote:
> diff --git a/drivers/mfd/max8997.c b/drivers/mfd/max8997.c
> index 5be53ae..cb83a7a 100644
> --- a/drivers/mfd/max8997.c
> +++ b/drivers/mfd/max8997.c
> @@ -43,7 +43,8 @@ static struct mfd_cell max8997_devs[] = {
> { .name = "max8997-battery", },
> { .name = "max8997-haptic", },
> { .name = "max8997-muic", },
> - { .name = "max8997-flash", },
That doesn't seem to be related to this patch.
> + { .name = "max8997-led", .id = 1 },
> + { .name = "max8997-led", .id = 2 },
> };
> @@ -172,7 +194,8 @@ struct max8997_platform_data {
>
> /* HAPTIC: Not implemented */
> /* RTC: Not implemented */
> - /* Flash: Not implemented */
> + /* ---- Flash ---- */
> + struct max8997_led_platform_data *led_pdata;
This is a bit confusing: Flash and LED ?
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
next prev parent reply other threads:[~2011-12-13 20:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-13 8:13 [PATCH RESEND 0/2] leds: add MAX8997-LED driver Donggeun Kim
2011-12-13 8:13 ` [PATCH RESEND 1/2] MFD: MAX8997: add platform data and devices for LED control Donggeun Kim
2011-12-13 20:59 ` Samuel Ortiz [this message]
2011-12-14 2:38 ` Donggeun Kim
2011-12-13 8:13 ` [PATCH RESEND 2/2] leds: add suuport for MAX8997-LED driver Donggeun Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111213205905.GH2796@sortiz-mobl \
--to=sameo@linux.intel.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=dg77.kim@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome