From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Peter Chubb <peter.chubb@nicta.com.au>
Cc: linux-kernel@vger.kernel.org, kexec@lists.infradead.org
Subject: Re: [PATCH] Fix kexec reboot on ARM
Date: Wed, 14 Dec 2011 08:08:02 +0000 [thread overview]
Message-ID: <20111214080802.GD14542@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <w4fwgnhkcd.wl%peter@chubb.wattle.id.au>
On Wed, Dec 14, 2011 at 03:02:10PM +1100, Peter Chubb wrote:
>
> When kexec() runs, it eventually sets up a 1-to-1 memory map, then
> invokes cpu_reset(). When it invokes cpu_reset (which turns
> off the MMU), it does so at its virtual address. Across the code that
> disables the MMU, virtual and physical addresses have to be the same,
> otherwise after disabling the MMU, the PC is invalid.
>
> The simplest fix is to invoke cpu_reset() at its one-to-one mapped
> address.
>
> I've tested on KZM (arm v6) and Beagleboard (omap)
NAK.
Three reasons:
1. You've not signed-off the patch (please read
Documentation/SubmittingPatches)
2. pre-ARMv6 do not expect this, and it will break where
PHYS_OFFSET >= PAGE_OFFSET
3. Have you seen what's already queued for the next merge window?
next prev parent reply other threads:[~2011-12-14 8:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-14 4:02 Peter Chubb
2011-12-14 8:08 ` Russell King - ARM Linux [this message]
2011-12-14 8:08 ` Russell King - ARM Linux
2011-12-14 10:36 ` Peter Chubb
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111214080802.GD14542@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.chubb@nicta.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®