From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755714Ab1LNIIu (ORCPT ); Wed, 14 Dec 2011 03:08:50 -0500 Received: from caramon.arm.linux.org.uk ([78.32.30.218]:52482 "EHLO caramon.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753892Ab1LNIIt (ORCPT ); Wed, 14 Dec 2011 03:08:49 -0500 Date: Wed, 14 Dec 2011 08:08:36 +0000 From: Russell King - ARM Linux To: Peter Chubb Cc: linux-kernel@vger.kernel.org, kexec@lists.infradead.org Subject: Re: [PATCH] Fix kexec reboot on ARM Message-ID: <20111214080836.GA15873@n2100.arm.linux.org.uk> References: <20111214080802.GD14542@n2100.arm.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20111214080802.GD14542@n2100.arm.linux.org.uk> User-Agent: Mutt/1.5.19 (2009-01-05) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 14, 2011 at 08:08:02AM +0000, Russell King - ARM Linux wrote: > On Wed, Dec 14, 2011 at 03:02:10PM +1100, Peter Chubb wrote: > > > > When kexec() runs, it eventually sets up a 1-to-1 memory map, then > > invokes cpu_reset(). When it invokes cpu_reset (which turns > > off the MMU), it does so at its virtual address. Across the code that > > disables the MMU, virtual and physical addresses have to be the same, > > otherwise after disabling the MMU, the PC is invalid. > > > > The simplest fix is to invoke cpu_reset() at its one-to-one mapped > > address. > > > > I've tested on KZM (arm v6) and Beagleboard (omap) > > NAK. > > Three reasons: > > 1. You've not signed-off the patch (please read > Documentation/SubmittingPatches) > 2. pre-ARMv6 do not expect this, and it will break where > PHYS_OFFSET >= PAGE_OFFSET > 3. Have you seen what's already queued for the next merge window? And 4. You didn't cc the linux-arm-kernel mailing list with your patch.