From: David Miller <davem@davemloft.net>
To: glommer@parallels.com
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
cgroups@vger.kernel.org, kamezawa.hiroyu@jp.fujitsu.com,
eric.dumazet@gmail.com, sfr@canb.auug.org.au
Subject: Re: [PATCH 2/2] Explicitly call tcp creation and init from memcontrol.c
Date: Thu, 15 Dec 2011 12:00:28 -0500 (EST) [thread overview]
Message-ID: <20111215.120028.532844419499092747.davem@davemloft.net> (raw)
In-Reply-To: <1323941672-14324-3-git-send-email-glommer@parallels.com>
From: Glauber Costa <glommer@parallels.com>
Date: Thu, 15 Dec 2011 13:34:32 +0400
> Walking the proto_list holds a read_lock, which prevents us from doing
> allocations. Splitting the tcp create function into create + init is
> good, but it is not enough since create_files will do allocations as well
> (dentry ones, mostly).
>
> Since this does not involve any protocol state, I propose we call the tcp
> functions explicitly from memcontrol.c
>
> With this, we lose by now the ability of doing cgroup memcontrol for
> protocols that are loaded as modules. But at least the ones I have in mind
> won't really need it (tcp_ipv6 being the only one, but it uses the same data
> structures as tcp_ipv4). So I believe this to be the simpler solution to this
> problem.
>
> Signed-off-by: Glauber Costa <glommer@parallels.com>
This is an unnecessary limitation, please fix this properly otherwise
DCCP, SCTP, etc. won't be supportable with this stuff.
next prev parent reply other threads:[~2011-12-15 17:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-15 9:34 [PATCH 0/2] Proposed fixes for tcp memory pressure Glauber Costa
2011-12-15 9:34 ` [PATCH 1/2] Move limit definitions outside CONFIG_INET Glauber Costa
2011-12-15 16:59 ` David Miller
2011-12-15 9:34 ` [PATCH 2/2] Explicitly call tcp creation and init from memcontrol.c Glauber Costa
2011-12-15 16:13 ` KAMEZAWA Hiroyuki
2011-12-15 16:18 ` Glauber Costa
2011-12-15 16:57 ` David Miller
2011-12-15 22:20 ` KAMEZAWA Hiroyuki
2011-12-16 2:06 ` Glauber Costa
2011-12-15 17:00 ` David Miller [this message]
2011-12-15 21:11 ` Glauber Costa
2011-12-15 22:44 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111215.120028.532844419499092747.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=cgroups@vger.kernel.org \
--cc=eric.dumazet@gmail.com \
--cc=glommer@parallels.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®