From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Linux PM list <linux-pm@vger.kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH 0/2 v2] PM / Sleep: Simplify generic system suspend callbacks
Date: Thu, 15 Dec 2011 00:19:39 +0100 [thread overview]
Message-ID: <201112150019.39645.rjw@sisk.pl> (raw)
In-Reply-To: <201112100005.24798.rjw@sisk.pl>
Hi Everyone,
One more udate here.
I forgot about the comments in this patch:
On Saturday, December 10, 2011, Rafael J. Wysocki wrote:
> On Sunday, November 27, 2011, Rafael J. Wysocki wrote:
> > From: Rafael J. Wysocki <rjw@sisk.pl>
> >
> > The pm_runtime_suspended() check in __pm_generic_call() doesn't
> > really help and may cause problems to happen, because in some cases
> > the system suspend callbacks need to be called even if the given
> > device has been suspended by runtime PM. For example, if the device
> > generally supports remote wakeup and is not enabled to wake up
> > the system from sleep, it should be prevented from generating wakeup
> > signals during system suspend and that has to be done by the
> > suspend callbacks that the pm_runtime_suspended() check prevents from
> > being executed.
> >
> > Similarly, it may not be a good idea to unconditionally change
> > the runtime PM status of the device to 'active' in
> > __pm_generic_resume(), because the driver may want to leave the
> > device in the 'suspended' state, depending on what happened to it
> > before the system suspend and whether or not it is enabled to
> > wake up the system.
> >
> > For the above reasons, remove the pm_runtime_suspended()
> > check from __pm_generic_call() and remove the code changing the
> > device's runtime PM status from __pm_generic_resume().
> >
> > Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
so the updated one becomes [1/2] in the new series.
In addition to that I noticed that __pm_generic_call() and
__pm_generic_resume() may be merged after [1/2], which is done by [2/2].
I regard these patches as 3.3 material, if there are no objections.
Thanks,
Rafael
next prev parent reply other threads:[~2011-12-14 23:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-17 23:37 [PATCH] PM / Sleep: Remove pm_runtime_suspended() from __pm_generic_call() Rafael J. Wysocki
2011-11-27 12:41 ` [PATCH] PM / Sleep: Simplify generic system suspend callbacks Rafael J. Wysocki
2011-12-09 23:05 ` Rafael J. Wysocki
2011-12-14 23:19 ` Rafael J. Wysocki [this message]
2011-12-14 23:20 ` [PATCH 1/2 v2] " Rafael J. Wysocki
2011-12-14 23:21 ` [PATCH 2/2 v2] PM / Sleep: Merge internal functions in generic_ops.c Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201112150019.39645.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome