mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Felipe Balbi <balbi@ti.com>
To: Greg KH <greg@kroah.com>
Cc: Felipe Contreras <felipe.contreras@gmail.com>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	Felipe Balbi <balbi@ti.com>, Greg Kroah-Hartman <gregkh@suse.de>,
	Jarkko Nikula <jarkko.nikula@bitmer.com>,
	stable@vger.kernel.org
Subject: Re: [PATCH] usb: musb: fix pm_runtime mismatch
Date: Fri, 16 Dec 2011 01:52:06 +0200	[thread overview]
Message-ID: <20111215235205.GB2242@legolas.emea.dhcp.ti.com> (raw)
In-Reply-To: <20111215231103.GB27434@kroah.com>

[-- Attachment #1: Type: text/plain, Size: 1570 bytes --]

On Thu, Dec 15, 2011 at 03:11:03PM -0800, Greg KH wrote:
> On Thu, Dec 15, 2011 at 03:02:25PM -0800, Greg KH wrote:
> > On Fri, Dec 16, 2011 at 12:42:14AM +0200, Felipe Contreras wrote:
> > > In musb_init_controller() there's a pm_runtime_put(), but there's no
> > > pm_runtime_get(), which creates a mismatch that causes the driver to
> > > sleep when it shouldn't.
> > > 
> > > This was introduced in 7acc619, but it wasn't triggered until 18a2689
> > > was merged to Linus' branch at point 6899608.
> > > 
> > > However, it seems most of the time this is used in a way that keeps the
> > > counter above 0, so nobody noticed. Also, it seems to depend on the
> > > configuration used.
> > > 
> > > I found the problem by loading isp1704_charger before any usb gadgets:
> > > http://article.gmane.org/gmane.linux.kernel/1226122
> > > 
> > > All versions after 2.6.39 are affected.
> > > 
> > > Cc: stable@vger.kernel.org
> > > Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
> > > ---
> > >  drivers/usb/musb/musb_core.c |    2 --
> > >  1 files changed, 0 insertions(+), 2 deletions(-)
> > 
> > Will you be including this in your next pull request for me to include
> > in my tree to go to Linus soon?
> 
> Doh, wrong Felipe, my apologies.

hehe. To answer the previous question: I want to hash a few things out
first, so it's likely that it won't make it for the next pull request to
Linus. Guess I'll have to send this either on 3.3 merge window or after
that and, of course, Cc stable (as Felipe C. did)

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

  reply	other threads:[~2011-12-15 23:52 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-15 22:42 Felipe Contreras
2011-12-15 23:01 ` Felipe Balbi
2011-12-15 23:31   ` Felipe Contreras
2011-12-15 23:50     ` Felipe Balbi
2011-12-16  1:13       ` Felipe Contreras
2011-12-16  1:38         ` Felipe Balbi
2011-12-19 19:39           ` Felipe Contreras
2011-12-15 23:02 ` Greg KH
2011-12-15 23:11   ` Greg KH
2011-12-15 23:52     ` Felipe Balbi [this message]
2011-12-16 10:46 ` Sergei Shtylyov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111215235205.GB2242@legolas.emea.dhcp.ti.com \
    --to=balbi@ti.com \
    --cc=felipe.contreras@gmail.com \
    --cc=greg@kroah.com \
    --cc=gregkh@suse.de \
    --cc=jarkko.nikula@bitmer.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®