mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Yinghai Lu <yinghai@kernel.org>
Cc: Nikunj A Dadhania <nikunj@linux.vnet.ibm.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	LKML <linux-kernel@vger.kernel.org>,
	x86@kernel.org, Suresh Siddha <suresh.b.siddha@intel.com>,
	Joerg Roedel <joerg.roedel@amd.com>
Subject: Re: Latest tip kernel(3.2-rc1-tip_cf6b3899) fails to boot on x3850x5 machine
Date: Fri, 16 Dec 2011 09:40:29 +0100	[thread overview]
Message-ID: <20111216084029.GB4170@elte.hu> (raw)
In-Reply-To: <CAE9FiQXh8tiJ0Aa80uGJBiVv_3-rirMt1roQwZ3dBws-p0=j9A@mail.gmail.com>


* Yinghai Lu <yinghai@kernel.org> wrote:

>  config X86_X2APIC
>  	bool "Support x2apic"
> -	depends on X86_LOCAL_APIC && X86_64 && IRQ_REMAP
> +	depends on X86_LOCAL_APIC && X86_64
> +	select IRQ_REMAP

IRQ_REMAP is a 'complex' option:

config IRQ_REMAP
        bool "Support for Interrupt Remapping (EXPERIMENTAL)"
        depends on X86_64 && X86_IO_APIC && PCI_MSI && ACPI && EXPERIMENTAL
        select DMAR_TABLE

and selecting such complex options is generally dangerous, as 
the sub-dependencies are not explicitly selected. So if say 
PCI_MSI or ACPI are disabled, the select will still be performed 
by X86_X2APIC.

Can we make the IRQ_REMAP default depend on X86_X2APIC or so, to 
solve this problem?

Thanks,

	Ingo

  parent reply	other threads:[~2011-12-16  8:42 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-14 10:48 Nikunj A Dadhania
2011-12-14 13:30 ` Thomas Gleixner
2011-12-14 20:17   ` Thomas Gleixner
2011-12-14 20:35     ` Yinghai Lu
2011-12-14 20:56       ` Thomas Gleixner
2011-12-15  2:24       ` Nikunj A Dadhania
2011-12-15  2:40         ` Yinghai Lu
2011-12-15  7:19           ` Ingo Molnar
2011-12-15 19:16             ` Yinghai Lu
2011-12-15 20:25               ` Suresh Siddha
2011-12-16  3:41                 ` Nikunj A Dadhania
2011-12-16  8:36                 ` Ingo Molnar
2011-12-17  2:10                   ` Suresh Siddha
2011-12-18  8:32                     ` Ingo Molnar
2011-12-16  8:40               ` Ingo Molnar [this message]
2011-12-16 18:03                 ` Yinghai Lu
2011-12-17  2:18                   ` Suresh Siddha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111216084029.GB4170@elte.hu \
    --to=mingo@elte.hu \
    --cc=joerg.roedel@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nikunj@linux.vnet.ibm.com \
    --cc=suresh.b.siddha@intel.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    --cc=yinghai@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome