From: "Richard W.M. Jones" <rjones@redhat.com>
To: Clemens Ladisch <clemens@ladisch.de>
Cc: alsa-devel@alsa-project.org, Tom Walder <tom.walder@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [alsa-devel] [PATCH] Jabra SPEAK 410 USB - no audio playback
Date: Fri, 16 Dec 2011 19:12:10 +0000 [thread overview]
Message-ID: <20111216191210.GI2520@amd.home.annexia.org> (raw)
In-Reply-To: <4EEB4C51.4010205@ladisch.de>
On Fri, Dec 16, 2011 at 02:49:05PM +0100, Clemens Ladisch wrote:
> Richard W.M. Jones wrote:
> > The attached patch fixes USB audio support for the Jabra SPEAK 410 USB.
> >
> > The problem, as I understand it, is that the device contains a
> > Class-Specific Endpoint (CS_ENDPOINT) descriptor before the Endpoint
> > (ENDPOINT) descriptor. The USB code all assumes that CS_ENDPOINT can
> > only appear after ENDPOINT. Therefore the USB code divides up the
> > interface descriptor into "stuff before ENDPOINT" (in
> > interface->extra) and "stuff after ENDPOINT" (in
> > interface->endpoint[0]->extra). For this device, this division does
> > not work.
> >
> > The solution (which is a hack ...) is to also search interface->extra
> > looking for the missing descriptor.
>
> The patch looks good. Please run it through checkpatch.pl and provice
> a Signed-off-by tag (see Documentation/SubmittingPatches).
Sorry, I should have followed up on this list ...
Tom (in the CC line) opened a bug with Jabra, and they have issued a
firmware update. Unfortunately this update requires some Windows
software to run. I applied this, and it does appear to fix the audio
playback problem, though curiously it doesn't completely fix the
ENDPOINT/CS_ENDPOINT problem, so who knows what's really going on
there.
Anyway, should you want the update it is here:
https://bugzilla.redhat.com/show_bug.cgi?id=766714#c1
Thanks Tom!
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
virt-df lists disk usage of guests without needing to install any
software inside the virtual machine. Supports Linux and Windows.
http://et.redhat.com/~rjones/virt-df/
prev parent reply other threads:[~2011-12-16 19:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20111210142419.GC16692@amd.home.annexia.org>
2011-12-10 19:45 ` Richard W.M. Jones
2011-12-13 22:14 ` [alsa-devel] " Richard W.M. Jones
2011-12-16 13:49 ` Clemens Ladisch
2011-12-16 19:12 ` Richard W.M. Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111216191210.GI2520@amd.home.annexia.org \
--to=rjones@redhat.com \
--cc=alsa-devel@alsa-project.org \
--cc=clemens@ladisch.de \
--cc=linux-kernel@vger.kernel.org \
--cc=tom.walder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®