From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Janusz Krzysztofik <jkrzyszt@tis.icnet.pl>
Cc: Nicolas Pitre <nicolas.pitre@linaro.org>,
Tony Lindgren <tony@atomide.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: Fix cross compilation broken by failing size command
Date: Sat, 17 Dec 2011 10:57:37 +0000 [thread overview]
Message-ID: <20111217105737.GO14542@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1324032146-723-1-git-send-email-jkrzyszt@tis.icnet.pl>
On Fri, Dec 16, 2011 at 11:42:26AM +0100, Janusz Krzysztofik wrote:
> Unfortunately, I've already pushed that old version to the patch system
> at http://www.arm.linux.org.uk/developer/patches/, which I know is not
> a review system. Apparently, I was not patient enough, not waiting more
> than a week with that regression fix for a single reply to my initial
I'll disagree with you there: this is not a regression fix. A regression
fix implies that it was something that worked before, a change happened
to the kernel, and now it's broken.
That is not the case: a change happened to binutils which meant 'size'
no longer parses foreign ELF formats. This is not a change to the
kernel, and therefore it is not a kernel regression.
Therefore, I consider it lower priority than true kernel regression
fixes, and also lower priority than normal bug fixes to the kernel:
it's actually a feature change - changing the kernel to work with a
new toolchain.
Since the original proposed change causes _me_ problems (I'm missing
an arm-linux-size for some unknown reason - which I've yet to resolve
one way or other) I've not yet considered the change any further than
noting that fact.
If it turns out that older versions of binutils do not supply a 'size'
command, then we need something like your v2 patch. If it's the case
that for some reason it never got transferred when I changed machines,
then your v1 patch is appropriate and I need to fix that. But that
requires investigation on my side, and I've not been able to do that
yet.
next prev parent reply other threads:[~2011-12-17 10:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <Message-ID: <20111214215815.GP32251@atomide.com>
2011-12-16 10:42 ` Janusz Krzysztofik
2011-12-17 0:30 ` Tony Lindgren
2011-12-17 10:57 ` Russell King - ARM Linux [this message]
2011-12-17 13:01 ` Janusz Krzysztofik
2011-12-17 16:38 ` Nicolas Pitre
2011-12-17 17:15 ` Russell King - ARM Linux
2011-12-17 18:57 ` Janusz Krzysztofik
2011-12-19 8:27 ` Igor Grinberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111217105737.GO14542@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=jkrzyszt@tis.icnet.pl \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolas.pitre@linaro.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®