From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751889Ab1LRQ1X (ORCPT ); Sun, 18 Dec 2011 11:27:23 -0500 Received: from cantor2.suse.de ([195.135.220.15]:52362 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751572Ab1LRQ1V (ORCPT ); Sun, 18 Dec 2011 11:27:21 -0500 Date: Sun, 18 Dec 2011 17:27:15 +0100 From: Michal Hocko To: linux-kernel@vger.kernel.org Cc: Thomas Gleixner , Arjan van de Ven , Kamalesh Babulal , Frederic Weisbecker Subject: [PATCH resend] nohz: Remove update_ts_time_stat from tick_nohz_start_idle Message-ID: <20111218162715.GA25717@tiehlicka.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org There is no reason to call update_ts_time_stat from tick_nohz_start_idle anymore (after e0e37c20 sched: Eliminate the ts->idle_lastupdate field) when we updated idle_lastupdate unconditionally. We haven't set idle_active yet and do not provide last_update_time so the whole call end up being just 2 wasted branches. Signed-off-by: Michal Hocko Reviewed-by: Frederic Weisbecker Reviewed-by: Kamalesh Babulal CC: Arjan van de Ven CC: Thomas Gleixner --- kernel/time/tick-sched.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/kernel/time/tick-sched.c b/kernel/time/tick-sched.c index 4042064..be3cab0 100644 --- a/kernel/time/tick-sched.c +++ b/kernel/time/tick-sched.c @@ -186,8 +186,6 @@ static ktime_t tick_nohz_start_idle(int cpu, struct tick_sched *ts) now = ktime_get(); - update_ts_time_stats(cpu, ts, now, NULL); - ts->idle_entrytime = now; ts->idle_active = 1; sched_clock_idle_sleep_event(); -- 1.7.7.3