From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: linux-kernel@vger.kernel.org,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Felipe Balbi" <balbi@ti.com>,
"Vladimir Zapolskiy" <vz@mleia.com>, "Liam Girdwood" <lrg@ti.com>
Subject: Re: [PATCH v4 3/4] regulator: simplify twl4030 config
Date: Tue, 20 Dec 2011 02:17:23 +0000 [thread overview]
Message-ID: <20111220021722.GA8257@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <CAMP44s3iSVEbghx9nGU-w9N+Bsdw040=UQtiw6RRyq021ssBxw@mail.gmail.com>
On Tue, Dec 20, 2011 at 04:04:14AM +0200, Felipe Contreras wrote:
> On Tue, Dec 20, 2011 at 3:53 AM, Mark Brown
> > Yes, of course. Half the point in having subsystems and standard ways
> > of doing things is so that when we look at things we've got a reasonable
> > idea as to what they're supposed to be doing and people looking at the
> > code can figure out what's going on. We don't want people to have to
> > play guessing games about this stuff.
> Of course... *ideally*, but we are not there right now.
We pretty much were, but this patch has changelog which says "I've got a
cool new way of doing things for this one driver!" which clearly applies
to other drivers. I wouldn't mind a patch which does this for all MFDs
(though I really do think it should be applied to most subsystems) but
doing it for one driver isn't great.
next prev parent reply other threads:[~2011-12-20 2:17 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-20 1:15 [PATCH v4 0/4] Simplifications on Kconfigs Felipe Contreras
2011-12-20 1:15 ` [PATCH v4 1/4] mfd: simplify twl4030_power config Felipe Contreras
2011-12-20 1:15 ` [PATCH v4 2/4] mfd: simplify twl4030_core config Felipe Contreras
2011-12-20 1:15 ` [PATCH v4 3/4] regulator: simplify twl4030 config Felipe Contreras
2011-12-20 1:19 ` Mark Brown
2011-12-20 1:36 ` Felipe Contreras
2011-12-20 1:53 ` Mark Brown
2011-12-20 2:04 ` Felipe Contreras
2011-12-20 2:17 ` Mark Brown [this message]
2011-12-20 1:25 ` Mark Brown
2011-12-20 1:43 ` Felipe Contreras
2011-12-20 1:15 ` [PATCH v4 4/4] usb: simplify hdrc configuration Felipe Contreras
2011-12-20 11:04 ` Felipe Balbi
2011-12-20 20:25 ` Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111220021722.GA8257@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=balbi@ti.com \
--cc=felipe.contreras@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=vz@mleia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®