From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752744Ab1LTHS0 (ORCPT ); Tue, 20 Dec 2011 02:18:26 -0500 Received: from mail-qw0-f53.google.com ([209.85.216.53]:63058 "EHLO mail-qw0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751414Ab1LTHST (ORCPT ); Tue, 20 Dec 2011 02:18:19 -0500 Date: Tue, 20 Dec 2011 16:18:04 +0900 From: Minchan Kim To: Mel Gorman Cc: Andrew Morton , Andrea Arcangeli , Minchan Kim , Dave Jones , Jan Kara , Andy Isaacson , Johannes Weiner , Rik van Riel , Nai Xia , Linux-MM , LKML Subject: Re: [PATCH 08/11] mm: compaction: Introduce sync-light migration for use by compaction Message-ID: <20111220071804.GB19025@barrios-laptop.redhat.com> References: <1323877293-15401-1-git-send-email-mgorman@suse.de> <1323877293-15401-9-git-send-email-mgorman@suse.de> <20111218020552.GB13069@barrios-laptop.redhat.com> <20111219114522.GK3487@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20111219114522.GK3487@suse.de> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 19, 2011 at 11:45:22AM +0000, Mel Gorman wrote: > On Sun, Dec 18, 2011 at 11:05:52AM +0900, Minchan Kim wrote: > > On Wed, Dec 14, 2011 at 03:41:30PM +0000, Mel Gorman wrote: > > > This patch adds a lightweight sync migrate operation MIGRATE_SYNC_LIGHT > > > mode that avoids writing back pages to backing storage. Async > > > compaction maps to MIGRATE_ASYNC while sync compaction maps to > > > MIGRATE_SYNC_LIGHT. For other migrate_pages users such as memory > > > hotplug, MIGRATE_SYNC is used. > > > > > > This avoids sync compaction stalling for an excessive length of time, > > > particularly when copying files to a USB stick where there might be > > > a large number of dirty pages backed by a filesystem that does not > > > support ->writepages. > > > > > > [aarcange@redhat.com: This patch is heavily based on Andrea's work] > > > Signed-off-by: Mel Gorman > > > > Acked-by: Minchan Kim > > > > Thanks. > > > > > > > diff --git a/fs/hugetlbfs/inode.c b/fs/hugetlbfs/inode.c > > > index 10b9883..6b80537 100644 > > > --- a/fs/hugetlbfs/inode.c > > > +++ b/fs/hugetlbfs/inode.c > > > @@ -577,7 +577,7 @@ static int hugetlbfs_set_page_dirty(struct page *page) > > > > > > static int hugetlbfs_migrate_page(struct address_space *mapping, > > > struct page *newpage, struct page *page, > > > - bool sync) > > > + enum migrate_mode mode) > > > > Nitpick, except this one, we use enum migrate_mode sync. > > > > Actually, in all the core code, I used "mode" but I was inconsistent in > the headers and some of the filesystems. I should have converted all use > of "sync" which was a boolean to a mode which has three possible values > after this patch. > > ==== CUT HERE ==== > mm: compaction: Introduce sync-light migration for use by compaction fix > > Consistently name enum migrate_mode parameters "mode" instead of "sync". > > Signed-off-by: Mel Gorman Acked-by: Minchan Kim Thanks. -- Kind regards, Minchan Kim