From: Felipe Balbi <balbi@ti.com>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: balbi@ti.com, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
Greg Kroah-Hartman <gregkh@suse.de>,
Jiri Kosina <trivial@kernel.org>
Subject: Re: [PATCH 1/3] usb: musb: fix pm_runtime mismatches
Date: Tue, 20 Dec 2011 13:19:38 +0200 [thread overview]
Message-ID: <20111220111935.GE31842@legolas.emea.dhcp.ti.com> (raw)
In-Reply-To: <CAMP44s2pbLRHB2ko9t-zQEpTFw=TaCS9b_qRmvAobgxeJ9WrCw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 615 bytes --]
On Mon, Dec 19, 2011 at 10:20:09PM +0200, Felipe Contreras wrote:
> On Mon, Dec 19, 2011 at 10:11 AM, Felipe Balbi <balbi@ti.com> wrote:
> > On Fri, Dec 16, 2011 at 01:05:08AM +0200, Felipe Contreras wrote:
> >> Properly call pm_runtime_put() afer pm_runttime_get() on errors.
> >>
> >> Untested.
> >
> > sorry, but I'm not applying untested patches. I need someone to give a
> > Tested-by.
>
> I'm pretty sure most people don't test the exit paths, but fine, don't
> apply them. Who needs power management anyway.
if it wasn't tested you can't claim $SUBJECT makes PM magically work.
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2011-12-20 11:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-15 23:05 [PATCH 0/3] musb fixes and cleanups Felipe Contreras
2011-12-15 23:05 ` [PATCH 1/3] usb: musb: fix pm_runtime mismatches Felipe Contreras
2011-12-15 23:22 ` Alan Stern
2011-12-16 0:59 ` Felipe Contreras
2011-12-16 3:30 ` Alan Stern
2011-12-19 20:21 ` Felipe Contreras
2011-12-19 8:11 ` Felipe Balbi
2011-12-19 20:20 ` Felipe Contreras
2011-12-20 11:19 ` Felipe Balbi [this message]
2011-12-20 19:43 ` Felipe Contreras
2011-12-15 23:05 ` [PATCH 2/3] usb: musb: trivial cleanup Felipe Contreras
2011-12-15 23:05 ` [PATCH 3/3] usb: musb: remove a bit of indentation Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111220111935.GE31842@legolas.emea.dhcp.ti.com \
--to=balbi@ti.com \
--cc=felipe.contreras@gmail.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®