mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Felipe Balbi <balbi@ti.com>
To: Felipe Contreras <felipe.contreras@nokia.com>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-omap <linux-omap@vger.kernel.org>,
	Felipe Balbi <balbi@ti.com>, Greg Kroah-Hartman <gregkh@suse.de>,
	Jarkko Nikula <jarkko.nikula@bitmer.com>,
	Felipe Contreras <felipe.contreras@gmail.com>,
	stable@vger.kernel.org, Hema HK <hemahk@ti.com>
Subject: Re: [PATCH v2] usb: musb: fix pm_runtime mismatch
Date: Tue, 20 Dec 2011 13:38:25 +0200	[thread overview]
Message-ID: <20111220113823.GJ31842@legolas.emea.dhcp.ti.com> (raw)
In-Reply-To: <1324324914-14584-1-git-send-email-felipe.contreras@nokia.com>

[-- Attachment #1: Type: text/plain, Size: 1298 bytes --]

On Mon, Dec 19, 2011 at 10:01:54PM +0200, Felipe Contreras wrote:
> From: Felipe Contreras <felipe.contreras@gmail.com>
> 
> In musb_init_controller() there's a pm_runtime_put(), but there's no
> pm_runtime_get(), which creates a mismatch that causes the driver to
> sleep when it shouldn't.
> 
> This was introduced in 7acc619[1], but it wasn't triggered in my setup
> until 18a2689[2] was merged to Linus' branch at point df0914[3]. IOW;
> when PM is working as it was supposed to.
> 
> However, it seems most of the time this is used in a way that keeps the
> counter above 0, so nobody noticed. Also, it seems to depend on the
> configuration used in versions before 3.1, but not later (or in it).
> 
> I found the problem by loading isp1704_charger before any usb gadgets:
> http://article.gmane.org/gmane.linux.kernel/1226122
> 
> All versions after 2.6.39 are affected.
> 
> [1] usb: musb: Idle path retention and offmode support for OMAP3
> [2] OMAP2+: musb: hwmod adaptation for musb registration
> [3] Merge branch 'omap-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap-2.6
> 
> Cc: stable@vger.kernel.org
> Cc: Hema HK <hemahk@ti.com>
> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>

applied, thanks

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

  reply	other threads:[~2011-12-20 11:38 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-19 20:01 Felipe Contreras
2011-12-20 11:38 ` Felipe Balbi [this message]
2012-01-12 11:56 ` Grazvydas Ignotas
2012-01-12 15:40   ` Felipe Contreras
2012-02-13 12:54     ` Grazvydas Ignotas
2012-02-13 15:06       ` Felipe Contreras

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111220113823.GJ31842@legolas.emea.dhcp.ti.com \
    --to=balbi@ti.com \
    --cc=felipe.contreras@gmail.com \
    --cc=felipe.contreras@nokia.com \
    --cc=gregkh@suse.de \
    --cc=hemahk@ti.com \
    --cc=jarkko.nikula@bitmer.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®