From: Chris Wright <chrisw@sous-sol.org>
To: "Hao, Xudong" <xudong.hao@intel.com>
Cc: Chris Wright <chrisw@sous-sol.org>,
"dwmw2@infradead.org" <dwmw2@infradead.org>,
"iommu@lists.linux-foundation.org"
<iommu@lists.linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Zhang, Xiantao" <xiantao.zhang@intel.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>
Subject: Re: [PATCH] intel-iommu: Add device info into list before doing context mapping
Date: Wed, 21 Dec 2011 10:48:11 -0800 [thread overview]
Message-ID: <20111221184811.GC961@sequoia.sous-sol.org> (raw)
In-Reply-To: <20111221184108.GB961@sequoia.sous-sol.org>
* Chris Wright (chrisw@sous-sol.org) wrote:
> * Hao, Xudong (xudong.hao@intel.com) wrote:
> > Yes, Chris, thanks your comments.
> > How about this one?
>
> Yes, it gets the locking right.
Sorry, I missed one other problem on the error path. You need to also
update pdev->dev.archdata.iommu to NULL (otherwise it is left pointing
to freed memory).
> Also makes host device and guest assigned device go through the same order:
>
> alloc_devinfo and init
> lock; place info on lists; unlock
> domain_context_mapping()
>
> The patch itself is whitespace damaged and does not apply. Please fix
> and feel free to add my:
>
> Acked-by: Chris Wright <chrisw@sous-sol.org>
next prev parent reply other threads:[~2011-12-21 18:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-17 13:06 Hao, Xudong
2011-12-20 16:07 ` Chris Wright
2011-12-21 2:04 ` Hao, Xudong
2011-12-21 18:41 ` Chris Wright
2011-12-21 18:48 ` Chris Wright [this message]
2011-12-20 10:47 Hao, Xudong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111221184811.GC961@sequoia.sous-sol.org \
--to=chrisw@sous-sol.org \
--cc=dwmw2@infradead.org \
--cc=iommu@lists.linux-foundation.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=xiantao.zhang@intel.com \
--cc=xudong.hao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome