From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Sangbeom Kim <sbkim73@samsung.com>
Cc: sameo@linux.intel.com, lrg@ti.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/5] mfd: Add S5M core driver
Date: Sat, 24 Dec 2011 18:41:44 +0000 [thread overview]
Message-ID: <20111224184142.GA10515@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1324628892-12170-2-git-send-email-sbkim73@samsung.com>
On Fri, Dec 23, 2011 at 05:28:08PM +0900, Sangbeom Kim wrote:
> S5M series are pmic including mutiple functional devices.
> It can support PMIC, RTC, Battery charger, codec.
> This patch implement core driver for s5m series.
Reviewed-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Looking good - a few nits that could be fixed incrementally unless
there's some reason to resend.
> +static struct regmap_config s5m_regmap_config = {
> + .reg_bits = 8,
> + .val_bits = 8,
> +};
It would be worth considering turning on the register cache support - it
can provide a nice performance win for read/modify/write operations by
cutting out the read from hardware. You don't need to provide any
defaults.
> + s5m87xx = kzalloc(sizeof(struct s5m87xx_dev), GFP_KERNEL);
> + if (s5m87xx == NULL)
> + return -ENOMEM;
devm_kzalloc() saves error handling and cleanup code.
next prev parent reply other threads:[~2011-12-24 18:41 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-23 8:28 [PATCH v2 0/5] Samsung S5M series initial release Sangbeom Kim
2011-12-23 8:28 ` [PATCH v2 1/5] mfd: Add S5M core driver Sangbeom Kim
2011-12-24 18:41 ` Mark Brown [this message]
2012-01-08 23:10 ` Samuel Ortiz
2011-12-23 8:28 ` [PATCH v2 2/5] mfd: Add s5m series irq driver Sangbeom Kim
2011-12-24 18:54 ` Mark Brown
2012-01-08 23:11 ` Samuel Ortiz
2011-12-23 8:28 ` [PATCH v3 3/5] mfd: Add S5M series configuration Sangbeom Kim
2012-01-08 23:12 ` Samuel Ortiz
2011-12-23 8:28 ` [PATCH v2 4/5] regulator: Add S5M8767 regulator driver Sangbeom Kim
2011-12-26 11:26 ` Mark Brown
2011-12-23 8:28 ` [PATCH v2 5/5] regulator: Add S5M8767 configuration Sangbeom Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111224184142.GA10515@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
--cc=sameo@linux.intel.com \
--cc=sbkim73@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome