From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753537Ab1LZBmT (ORCPT ); Sun, 25 Dec 2011 20:42:19 -0500 Received: from db3ehsobe005.messaging.microsoft.com ([213.199.154.143]:36968 "EHLO DB3EHSOBE005.bigfish.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752986Ab1LZBmN convert rfc822-to-8bit (ORCPT ); Sun, 25 Dec 2011 20:42:13 -0500 X-SpamScore: -9 X-BigFish: VS-9(zzc89bh1432N98dKzz1202hzz8275bh8275dhz2dh2a8h668h839h) X-Forefront-Antispam-Report: CIP:70.37.183.190;KIP:(null);UIP:(null);IPV:NLI;H:mail.freescale.net;RD:none;EFVD:NLI X-FB-SS: 13, Date: Mon, 26 Dec 2011 09:55:44 +0800 From: Shawn Guo To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= CC: , , , Shawn Guo , Alan Cox , Grant Likely , Jeremy Kerr , Jason Liu , Sascha Hauer , Greg Kroah-Hartman Subject: Re: [PATCH] serial/imx: propagate error from of_alias_get_id instead of using -ENODEV Message-ID: <20111226015543.GG8240@S2100-06.ap.freescale.net> References: <1323894411-12294-1-git-send-email-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline In-Reply-To: <1323894411-12294-1-git-send-email-u.kleine-koenig@pengutronix.de> User-Agent: Mutt/1.5.21 (2010-09-15) Content-Transfer-Encoding: 8BIT X-OriginatorOrg: freescale.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 14, 2011 at 09:26:51PM +0100, Uwe Kleine-König wrote: > A quick look at of_alias_get_id shows that in the error case it returns > -ENODEV, too, but still it's better style to propagate the value as is. > > Signed-off-by: Uwe Kleine-König > Cc: Shawn Guo > Cc: Alan Cox > Cc: Grant Likely > Cc: Jeremy Kerr > Cc: Jason Liu > Cc: Sascha Hauer I queued this for 3.3, and will send a pull-request to Greg. -- Regards, Shawn