From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753811Ab1L0M7t (ORCPT ); Tue, 27 Dec 2011 07:59:49 -0500 Received: from cantor2.suse.de ([195.135.220.15]:42986 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753450Ab1L0M7s (ORCPT ); Tue, 27 Dec 2011 07:59:48 -0500 Date: Tue, 27 Dec 2011 13:59:45 +0100 From: Michal Hocko To: Hillf Danton Cc: linux-mm@kvack.org, LKML , Andrew Morton , KAMEZAWA Hiroyuki Subject: Re: [PATCH] mm: hugetlb: add might_sleep() for gigantic page Message-ID: <20111227125945.GH5344@tiehlicka.suse.cz> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri 23-12-11 21:41:08, Hillf Danton wrote: > From: Hillf Danton > Subject: [PATCH] mm: hugetlb: add might_sleep() for gigantic page > > Like the case of huge page, might_sleep() is added for gigantic page, then > both are treated in same way. Why do we need to call might_sleep here? There is cond_resched in the loop... > > Cc: Michal Hocko > Cc: KAMEZAWA Hiroyuki > Cc: Andrew Morton > Signed-off-by: Hillf Danton > --- > > --- a/mm/hugetlb.c Tue Dec 20 21:26:30 2011 > +++ b/mm/hugetlb.c Fri Dec 23 21:19:18 2011 > @@ -401,6 +401,7 @@ static void copy_gigantic_page(struct pa > struct page *dst_base = dst; > struct page *src_base = src; > > + might_sleep(); > for (i = 0; i < pages_per_huge_page(h); ) { > cond_resched(); > copy_highpage(dst, src); > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- Michal Hocko SUSE Labs SUSE LINUX s.r.o. Lihovarska 1060/12 190 00 Praha 9 Czech Republic