From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753970Ab1L0Nj5 (ORCPT ); Tue, 27 Dec 2011 08:39:57 -0500 Received: from cantor2.suse.de ([195.135.220.15]:44076 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753895Ab1L0Njy (ORCPT ); Tue, 27 Dec 2011 08:39:54 -0500 Date: Tue, 27 Dec 2011 14:39:52 +0100 From: Michal Hocko To: Hillf Danton Cc: linux-mm@kvack.org, LKML , Andrew Morton , KAMEZAWA Hiroyuki Subject: Re: [PATCH] mm: hugetlb: add might_sleep() for gigantic page Message-ID: <20111227133952.GJ5344@tiehlicka.suse.cz> References: <20111227125945.GH5344@tiehlicka.suse.cz> <20111227133021.GI5344@tiehlicka.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue 27-12-11 21:38:59, Hillf Danton wrote: > On Tue, Dec 27, 2011 at 9:30 PM, Michal Hocko wrote: > > On Tue 27-12-11 21:21:18, Hillf Danton wrote: > >> On Tue, Dec 27, 2011 at 8:59 PM, Michal Hocko wrote: > >> > On Fri 23-12-11 21:41:08, Hillf Danton wrote: > >> >> From: Hillf Danton > >> >> Subject: [PATCH] mm: hugetlb: add might_sleep() for gigantic page > >> >> > >> >> Like the case of huge page, might_sleep() is added for gigantic page, then > >> >> both are treated in same way. > >> > > >> > Why do we need to call might_sleep here? There is cond_resched in the > >> > loop... > >> > > >> > >> IIUC it is the reason to add... and the comment says > > > > cond_resched calls __might_sleep so there is no reason to call > > might_sleep outside the loop as well. > > > Yes, thanks. And remove it in the huge page case? Yes, makes sense. -- Michal Hocko SUSE Labs SUSE LINUX s.r.o. Lihovarska 1060/12 190 00 Praha 9 Czech Republic