From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754199Ab1L0OIN (ORCPT ); Tue, 27 Dec 2011 09:08:13 -0500 Received: from cantor2.suse.de ([195.135.220.15]:45002 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754046Ab1L0OIL (ORCPT ); Tue, 27 Dec 2011 09:08:11 -0500 Date: Tue, 27 Dec 2011 15:08:09 +0100 From: Michal Hocko To: "Kirill A. Shutemov" Cc: linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, containers@lists.linux-foundation.org, KAMEZAWA Hiroyuki , Balbir Singh , Johannes Weiner Subject: Re: [PATCH 3/6] memcg: remove unused variable Message-ID: <20111227140809.GM5344@tiehlicka.suse.cz> References: <1324695619-5537-1-git-send-email-kirill@shutemov.name> <1324695619-5537-3-git-send-email-kirill@shutemov.name> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1324695619-5537-3-git-send-email-kirill@shutemov.name> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat 24-12-11 05:00:16, Kirill A. Shutemov wrote: > From: "Kirill A. Shutemov" > > mm/memcontrol.c: In function ‘mc_handle_file_pte’: > mm/memcontrol.c:5206:16: warning: variable ‘inode’ set but not used [-Wunused-but-set-variable] > > Signed-off-by: Kirill A. Shutemov Looks good. Acked-by: Michal Hocko Thanks! > --- > mm/memcontrol.c | 2 -- > 1 files changed, 0 insertions(+), 2 deletions(-) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index 4bac3a2..627c19e 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -5203,7 +5203,6 @@ static struct page *mc_handle_file_pte(struct vm_area_struct *vma, > unsigned long addr, pte_t ptent, swp_entry_t *entry) > { > struct page *page = NULL; > - struct inode *inode; > struct address_space *mapping; > pgoff_t pgoff; > > @@ -5212,7 +5211,6 @@ static struct page *mc_handle_file_pte(struct vm_area_struct *vma, > if (!move_file()) > return NULL; > > - inode = vma->vm_file->f_path.dentry->d_inode; > mapping = vma->vm_file->f_mapping; > if (pte_none(ptent)) > pgoff = linear_page_index(vma, addr); > -- > 1.7.7.3 > -- Michal Hocko SUSE Labs SUSE LINUX s.r.o. Lihovarska 1060/12 190 00 Praha 9 Czech Republic