From: Francois Romieu <romieu@fr.zoreil.com>
To: Bjarke Istrup Pedersen <gurligebis@gentoo.org>
Cc: David Miller <davem@davemloft.net>,
shemminger@vyatta.com, bhutchings@solarflare.com,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
rl@hellgate.ch
Subject: Re: [PATCH 1/1] via-rhine: Split driver into .c and .h files.
Date: Sun, 1 Jan 2012 23:49:09 +0100 [thread overview]
Message-ID: <20120101224909.GA18144@electric-eye.fr.zoreil.com> (raw)
In-Reply-To: <1325452525-23476-1-git-send-email-gurligebis@gentoo.org>
Bjarke Istrup Pedersen <gurligebis@gentoo.org> :
> Split the driver into via-rhine.c and via-rhine.h like it should be.
> There is also a bit of cleanup of checkpatch warnings, other than that,
> there is no changes to how the code works, it is plain refactoring.
Please don't do that. The .h won't be used elsewhere. It's useless
(and register definitions stay barely readable).
Roger, any comment regarding patches #1 .. #3 ?
rhine_task_{enable / disable} should be balanced in open / close and
suspend / resume, ok.
--
Ueimor
next prev parent reply other threads:[~2012-01-01 22:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-01 21:15 Bjarke Istrup Pedersen
2012-01-01 22:49 ` Francois Romieu [this message]
2012-01-02 8:44 ` Bjarke Istrup Pedersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120101224909.GA18144@electric-eye.fr.zoreil.com \
--to=romieu@fr.zoreil.com \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=gurligebis@gentoo.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rl@hellgate.ch \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®