mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andreas Friedrich <afrie@gmx.net>
To: Rabin Vincent <rabin@rab.in>
Cc: john.stultz@linaro.org, gregkh@suse.de, torvalds@osdl.org,
	Wolfgang Erig <Wolfgang.Erig@ts.fujitsu.com>,
	linux-kernel@vger.kernel.org, rtc-linux@googlegroups.com
Subject: Re: REGRESSION 3.2-rcX: RTC auto poweron after 5 minutes
Date: Tue, 3 Jan 2012 00:10:07 +0100	[thread overview]
Message-ID: <20120102231007.GB23080@upset.ux.pdb.fsc.net> (raw)
In-Reply-To: <CAH+eYFBuK+-md-9QPQ8Z4DSNvKbyOEHg0EyRa2-DaVOZFi=hYQ@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1458 bytes --]

On Di, Dez 27, 2011 at 08:07:05 +0530, Rabin Vincent wrote:

Hello Rabin,
...
> Perhaps we can avoid your five-minute problem by just attempting
> to disable the irq without setting a new alarm time (not yet tested):
> 
> diff --git a/drivers/rtc/interface.c b/drivers/rtc/interface.c
...
I have tested your patch and for me it works!

> btw, if you haven't done so yet, could you please confirm that it's not
> something in your userspace which is _asking_ for the alarm to be
> enabled?  You could add a printk() of the 'enabled' argument into
> cmos_alarm_irq_enable() to do this (and one in cmos_set_alarm()
> wouldn't hurt too).

No, I haven't done this test, because my environment didn't change
when testing the two different kernel versions.

Nevertheless I have added the printk() calls starting with the string
'afrie:' in cmos_alarm_irq_enable() and cmos_set_alarm(). The console
output was captured by a second PC via serial line:

When booting there are no extra log messages (see boot.log).

Wenn calling 'init 0' there are 3 extra messages. I have tested it
with and without your patch (refer to init_0_with_patch.log and
init_0_without_patch.log). The last one is always a 'disable' message
but I found the following difference: In the 'patched' case the
disable message comes from cmos_alarm_irq_enable(). In the other case
the disable message comes from cmos_set_alarm(). May be you can
explain what's going on?

With best regards,
Andreas

[-- Attachment #2: logs.tar.gz --]
[-- Type: application/x-compressed-tar, Size: 13336 bytes --]

  reply	other threads:[~2012-01-02 23:10 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-26 14:58 Andreas Friedrich
2011-12-27 10:57 ` Andreas Friedrich
2011-12-27 14:37   ` Rabin Vincent
2012-01-02 23:10     ` Andreas Friedrich [this message]
2012-01-03 20:00     ` John Stultz
2012-01-24  0:31     ` John Stultz
2012-01-28  3:52       ` Rabin Vincent

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120102231007.GB23080@upset.ux.pdb.fsc.net \
    --to=afrie@gmx.net \
    --cc=Wolfgang.Erig@ts.fujitsu.com \
    --cc=gregkh@suse.de \
    --cc=john.stultz@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rabin@rab.in \
    --cc=rtc-linux@googlegroups.com \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®