mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Konstantin Khlebnikov <khlebnikov@openvz.org>
Cc: Greg KH <gregkh@suse.de>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] tty: rework pty count limiting
Date: Tue, 3 Jan 2012 00:43:25 +0000	[thread overview]
Message-ID: <20120103004325.0014b646@pyramind.ukuu.org.uk> (raw)
In-Reply-To: <4F022DFA.1090105@openvz.org>

> > That's a userspace api change, why is this going to be allowed?
> 
> open() can return -ENOSPC in case normal fs,
> meanwhile error codes for /dev/ptmx wasn't documented at all:
> there is nothing in manpage pts, pty and ptmx.
> manpage posix_openpt and getpt refers to manpage open(2).
> I can return EIO back, if this is critical.

I prefer the -ENOSPC change - its perfectly within POSIX and while its
vaguely an ABI change I don't believe its one that a single piece of
software actually cares about. So nothing will break (famous last words).

Lets try it and see.

Alan

  reply	other threads:[~2012-01-03  0:42 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-02 17:22 [PATCH 1/2] tty: move pty count limiting into devpts Konstantin Khlebnikov
2012-01-02 17:23 ` [PATCH 2/2] tty: rework pty count limiting Konstantin Khlebnikov
2012-01-02 17:29   ` Greg KH
2012-01-02 22:21     ` Konstantin Khlebnikov
2012-01-03  0:43       ` Alan Cox [this message]
2012-01-05  0:24 ` [PATCH 1/2] tty: move pty count limiting into devpts Greg KH
2012-01-05  9:06   ` [PATCH for tty-next " Konstantin Khlebnikov
2012-01-05  9:06   ` [PATCH for tty-next 2/2] tty: rework pty count limiting Konstantin Khlebnikov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120103004325.0014b646@pyramind.ukuu.org.uk \
    --to=alan@lxorguk.ukuu.org.uk \
    --cc=gregkh@suse.de \
    --cc=khlebnikov@openvz.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome