From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754716Ab2ACSxP (ORCPT ); Tue, 3 Jan 2012 13:53:15 -0500 Received: from charlotte.tuxdriver.com ([70.61.120.58]:35877 "EHLO smtp.tuxdriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754516Ab2ACSxN (ORCPT ); Tue, 3 Jan 2012 13:53:13 -0500 Date: Tue, 3 Jan 2012 13:53:05 -0500 From: Neil Horman To: David Miller Cc: linux-kernel@vger.kernel.org, jbarnes@virtuousgeek.org, bhelgaas@google.com, gregkh@suse.de, linux-pci@vger.kernel.org Subject: Re: [PATCH] msi: fix imbalanced refcount of msi irq sysfs objects Message-ID: <20120103185304.GA25184@hmsreliant.think-freely.org> References: <1325604594-7184-1-git-send-email-nhorman@tuxdriver.com> <20120103.130526.2034128205205666131.davem@davemloft.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120103.130526.2034128205205666131.davem@davemloft.net> User-Agent: Mutt/1.5.21 (2010-09-15) X-Spam-Score: -2.9 (--) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 03, 2012 at 01:05:26PM -0500, David Miller wrote: > From: Neil Horman > Date: Tue, 3 Jan 2012 10:29:54 -0500 > > > This warning was recently reported to me: > > I've hit this too, see: > > http://marc.info/?l=linux-kernel&m=132458146927890&w=2 > > and my analysis at: > > http://marc.info/?l=linux-arch&m=132458391128660&w=2 > Yup, your analysis is correct. Regardless of the why behind msi enablement failing, we need to gate the kobject_del/put in free_msi_irqs on successful completion of kobject_init_and_add in populate_msi_sysfs. This patch does that, using the parent pointer as a flag. Thanks Neil