From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752721Ab2ADIqQ (ORCPT ); Wed, 4 Jan 2012 03:46:16 -0500 Received: from cantor2.suse.de ([195.135.220.15]:57274 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751275Ab2ADIqO (ORCPT ); Wed, 4 Jan 2012 03:46:14 -0500 Date: Wed, 4 Jan 2012 09:46:11 +0100 From: Michal Hocko To: kosaki.motohiro@gmail.com Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, KOSAKI Motohiro , KAMEZAWA Hiroyuki , Johannes Weiner , cgroups@vger.kernel.org Subject: Re: [PATCH 1/2] memcg: root_mem_cgroup makes static Message-ID: <20120104084611.GA12581@tiehlicka.suse.cz> References: <1325633632-9978-1-git-send-email-kosaki.motohiro@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1325633632-9978-1-git-send-email-kosaki.motohiro@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue 03-01-12 18:33:51, kosaki.motohiro@gmail.com wrote: > From: KOSAKI Motohiro > > root_mem_cgroup is only referenced from memcontrol.c. It should be static. This has been already posted by Kirill https://lkml.org/lkml/2011/12/23/292 > > Signed-off-by: KOSAKI Motohiro > Cc: KAMEZAWA Hiroyuki > Cc: Johannes Weiner > Cc: Michal Hocko , > Cc: cgroups@vger.kernel.org > --- > mm/memcontrol.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index 90fdaeb..6adeeec 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -59,7 +59,7 @@ > > struct cgroup_subsys mem_cgroup_subsys __read_mostly; > #define MEM_CGROUP_RECLAIM_RETRIES 5 > -struct mem_cgroup *root_mem_cgroup __read_mostly; > +static struct mem_cgroup *root_mem_cgroup __read_mostly; > > #ifdef CONFIG_CGROUP_MEM_RES_CTLR_SWAP > /* Turned on only when memory cgroup is enabled && really_do_swap_account = 1 */ > -- > 1.7.1 > > -- > To unsubscribe from this list: send the line "unsubscribe cgroups" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Michal Hocko SUSE Labs SUSE LINUX s.r.o. Lihovarska 1060/12 190 00 Praha 9 Czech Republic