From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Fabio Estevam <festevam@gmail.com>,
linux-kernel@vger.kernel.org,
Fabio Estevam <fabio.estevam@freescale.com>
Subject: Re: [PATCH] include: crash_dump.h: Add elf.h header
Date: Wed, 4 Jan 2012 21:56:23 +0000 [thread overview]
Message-ID: <20120104215623.GI11810@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20120104122805.103eb7e2.akpm@linux-foundation.org>
On Wed, Jan 04, 2012 at 12:28:05PM -0800, Andrew Morton wrote:
> The patch is the right thing to do, however I'm rather concerned about
> the potential for introducing build breakage so late in 3.2.
>
> Can we leave this unfixed in 3.2 and fix it in 3.2.1? Or put a
> #include elf.h into arch/arm/kernel/setup.c for 3.2?
arch/arm/kernel/setup.c doesn't need either of these includes. The
reason I didn't want to just remove the include and magic the error
away is because of the obvious fragility of the current situation,
which really needs solving.
As this is the only report of this breakage, I'm inclined to go
with your first suggestion: leave it unfixed in 3.2 and fix it in
-stable once it's been in visible for a bit.
prev parent reply other threads:[~2012-01-04 21:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-04 12:04 Fabio Estevam
2012-01-04 20:28 ` Andrew Morton
2012-01-04 21:56 ` Russell King - ARM Linux [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120104215623.GI11810@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=akpm@linux-foundation.org \
--cc=fabio.estevam@freescale.com \
--cc=festevam@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome