mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Shawn Guo <shawn.guo@linaro.org>
To: Richard Zhao <richard.zhao@freescale.com>
Cc: Richard Zhao <richard.zhao@linaro.org>,
	Arnd Bergmann <arnd@arndb.de>,
	patches@linaro.org, vinod.koul@intel.com,
	linux-kernel@vger.kernel.org, eric.miao@linaro.org,
	kernel@pengutronix.de, dan.j.williams@intel.com,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 2/2] dma/imx-sdma: use writel to write register when enable a channel
Date: Thu, 5 Jan 2012 17:54:15 +0800	[thread overview]
Message-ID: <20120105095413.GD1729@S2101-09.ap.freescale.net> (raw)
In-Reply-To: <20120105091904.GO2414@b20223-02.ap.freescale.net>

On Thu, Jan 05, 2012 at 05:19:05PM +0800, Richard Zhao wrote:
> Russel mentioned that too. But I cannot understand.
> If CONFIG_ARM_DMA_MEM_BUFFERABLE, readl/writel always call rmb/wmb. Do
> we realy need it? It might affect performance.
> 
For safety, I think we need it.  The operations should be really fast.

-- 
Regards,
Shawn

      parent reply	other threads:[~2012-01-05  9:44 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-05  7:59 [PATCH v3 0/2] imx-sdma: memory barrier fix Richard Zhao
2012-01-05  7:59 ` [PATCH v3 1/2] dma/imx-sdma: let sdma_run_channel call sdma_enable_channel Richard Zhao
2012-01-05  9:14   ` Shawn Guo
2012-01-05  7:59 ` [PATCH v3 2/2] dma/imx-sdma: use writel to write register when enable a channel Richard Zhao
2012-01-05  9:23   ` Shawn Guo
2012-01-05  9:19     ` Richard Zhao
2012-01-05  9:34       ` Eric Miao
2012-01-05  9:54       ` Shawn Guo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120105095413.GD1729@S2101-09.ap.freescale.net \
    --to=shawn.guo@linaro.org \
    --cc=arnd@arndb.de \
    --cc=dan.j.williams@intel.com \
    --cc=eric.miao@linaro.org \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=patches@linaro.org \
    --cc=richard.zhao@freescale.com \
    --cc=richard.zhao@linaro.org \
    --cc=vinod.koul@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®